Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename unreleased watcher ext methods slightly #906

Merged
merged 4 commits into from May 11, 2022
Merged

Conversation

clux
Copy link
Member

@clux clux commented May 11, 2022

as suggested by #899 (review)

the longer name here i think reads better than a short applied because it is sometimes a bit weird to have stuff like:

reflector(x,y).applied().boxed()

makes applied be possible to interpret as some sort of functional transformer

as suggested by #899 (review)

Signed-off-by: clux <sszynrae@gmail.com>
@jesperpedersen
Copy link

.targets() ? Don't know if that is better though...

Signed-off-by: clux <sszynrae@gmail.com>
@clux
Copy link
Member Author

clux commented May 11, 2022

.targets() ? Don't know if that is better though...

Probably not. We need to distinguish between applied objects and touched objects.
Anyway, actual agreement on this. Going to merge after if stuff passes after small doc updates.

@clux clux added this to the 0.72.0 milestone May 11, 2022
@clux clux added the changelog-exclude changelog excluded prs label May 11, 2022
@clux
Copy link
Member Author

clux commented May 11, 2022

Marking this as exclude because it's not a breaking change if it hasn't been released yet 🙃

@codecov-commenter

This comment was marked as off-topic.

clux added 2 commits May 11, 2022 22:35
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux merged commit d0bf02f into master May 11, 2022
@clux clux deleted the watcher-method-renames branch May 11, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants