Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GroupVersion::with_kind and TypeMeta -> GroupVersionKind converters #896

Merged
merged 6 commits into from May 5, 2022

Conversation

clux
Copy link
Member

@clux clux commented May 4, 2022

for more efficiently working with kubernetes disk format.
was kind of boilerplatey to do elsewhere.

for working with kubernetes disk format.

Signed-off-by: clux <sszynrae@gmail.com>
clux added a commit that referenced this pull request May 4, 2022
Can apply yaml from multidoc files using helpers from #896

Signed-off-by: clux <sszynrae@gmail.com>
@clux clux added the changelog-add changelog added category for prs label May 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2022

Codecov Report

Merging #896 (826ba9b) into master (b7b7d8a) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
+ Coverage   70.35%   70.47%   +0.11%     
==========================================
  Files          62       62              
  Lines        4264     4281      +17     
==========================================
+ Hits         3000     3017      +17     
  Misses       1264     1264              
Impacted Files Coverage Δ
kube-core/src/gvk.rs 82.60% <100.00%> (+10.19%) ⬆️

clux added 3 commits May 4, 2022 22:40
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux requested a review from kazk May 4, 2022 22:07
kube-core/src/gvk.rs Outdated Show resolved Hide resolved
Signed-off-by: clux <sszynrae@gmail.com>
Copy link
Member

@kazk kazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title needs to be updated.

kube-core/Cargo.toml Outdated Show resolved Hide resolved
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux changed the title Add GroupVersion::with_kind and GroupVersionKind::from_yaml helpers Add GroupVersion::with_kind and TypeMeta -> GroupVersionKind converters May 5, 2022
@clux clux added this to the 0.72.0 milestone May 5, 2022
@clux clux merged commit 2459b72 into master May 5, 2022
@clux clux deleted the core-gvkexts branch May 5, 2022 09:25
clux added a commit that referenced this pull request May 5, 2022
Can apply yaml from multidoc files using helpers from #896

Signed-off-by: clux <sszynrae@gmail.com>
clux added a commit that referenced this pull request May 6, 2022
Can apply yaml from multidoc files using helpers from #896

Signed-off-by: clux <sszynrae@gmail.com>
clux added a commit that referenced this pull request May 11, 2022
* Extend kubectl with apply method

Can apply yaml from multidoc files using helpers from #896

Signed-off-by: clux <sszynrae@gmail.com>

* rebase with new helpers

Signed-off-by: clux <sszynrae@gmail.com>

* extra error case

Signed-off-by: clux <sszynrae@gmail.com>

* add edit support as well

ok i will stop now. this is surprisingly easy.

Signed-off-by: clux <sszynrae@gmail.com>

* avoid awkward cloning

Signed-off-by: clux <sszynrae@gmail.com>

* managed fields tweak

Signed-off-by: clux <sszynrae@gmail.com>

* add note after finding out kubectl is smart

Signed-off-by: clux <sszynrae@gmail.com>

* less import after rebase

Signed-off-by: clux <sszynrae@gmail.com>

* cleanup into methods on clap inst

Signed-off-by: clux <sszynrae@gmail.com>

* cleanup dynamic_api example a bit

no need to use NAMESPACE evars. people can use kns or similar to change
namespace. rely on default_namespaced.

Signed-off-by: clux <sszynrae@gmail.com>

* remove NAMESPACE evars across examples + configmap_watcher

better to let people rely on default_namespaced and switch with kns
also updates docs for these

Signed-off-by: clux <sszynrae@gmail.com>

* fix log_stream example

Signed-off-by: clux <sszynrae@gmail.com>

* fix warning + build

Signed-off-by: clux <sszynrae@gmail.com>

* make verb an enum

Signed-off-by: clux <sszynrae@gmail.com>

* one less clone and tweak sentence

Signed-off-by: clux <sszynrae@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-add changelog added category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants