Add ResourceExt::creation_timestamp #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clux
commented
Apr 18, 2022
kube-core/src/resource.rs
Outdated
| @@ -225,4 +233,8 @@ impl<K: Resource> ResourceExt for K { | |||
| fn finalizers_mut(&mut self) -> &mut Vec<String> { | |||
| self.meta_mut().finalizers.get_or_insert_with(Vec::new) | |||
| } | |||
|
|
|||
| fn creation(&self) -> Option<Time> { | |||
| self.meta().creation_timestamp.clone() | |||
There was a problem hiding this comment.
it is possible that this method should reach into the inner chrono DateTime since the k8s-openapi one is just a wrapper for it.
EDIT: but that's probably a deref issue for the serialization layer rather than us forcing a .0
Codecov Report
@@ Coverage Diff @@
## master #888 +/- ##
==========================================
- Coverage 70.39% 70.34% -0.06%
==========================================
Files 62 62
Lines 4287 4289 +2
==========================================
- Hits 3018 3017 -1
- Misses 1269 1272 +3
|
kazk
reviewed
May 6, 2022
kube-core/src/resource.rs
Outdated
| /// Returns the creation timestamp | ||
| /// | ||
| /// This is guaranteed to exist on resources received by the apiserver. | ||
| fn creation(&self) -> Option<Time>; |
There was a problem hiding this comment.
creation sound awkward to me. created_at?
There was a problem hiding this comment.
hm, actually, it might be smarter to go for the full creation_timestamp name here upon reflection; because everything else is named exactly after the names in ObjectMeta
shortcut method to access a cloned creation timestamp Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
clux
force-pushed
the
resource-ext-creation
branch
from
40aa4c1
to
992f622
Compare
kazk
approved these changes
May 6, 2022
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
kazk
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shortcut method to access a cloned creation timestamp.