Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to kubernetes cluster dns for incluster url everywhere #876

Merged
merged 3 commits into from Apr 13, 2022
Merged

Switch to kubernetes cluster dns for incluster url everywhere #876

merged 3 commits into from Apr 13, 2022

Conversation

clux
Copy link
Member

@clux clux commented Apr 13, 2022 •
edited

This is the recommended, and now only documented method.
The legacy method has issues with ipv6 (#874) and it's time to retire it instead of trying to keep it going.

We trialled the new method for 6months via #587 without any reports.

@clux
Switch to kubernetes dns for incluster url everywhere
9916723 
This is the recommended, and only documented method on https://kubernetes.io/docs/tasks/run-application/access-api-from-pod/
The legacy method has issues with ipv6 and it's time to retire it.

We trialled the new method for 6months via #587 without any reports.

Closes #874

Signed-off-by: clux <sszynrae@gmail.com>
@clux
remove code for legacy methods, was never actually made public
258fd52 
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux added this to the 0.72.0 milestone Apr 13, 2022
@clux clux added the changelog-change changelog change category for prs label Apr 13, 2022
@clux clux linked an issue Apr 13, 2022 that may be closed by this pull request
In-cluster didn't format correct kube_host_port for IPv6 cluster #874
Closed
@clux clux requested a review from a team April 13, 2022 09:30
@clux
simplify kube_dns fn with less unwraps
e529292 
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux merged commit dd0b258 into master Apr 13, 2022
@clux clux deleted the remove-legacy-incluster branch April 13, 2022 19:33
@clux
Copy link
Member Author

clux commented Apr 13, 2022 •
edited

tested with controller-rs for sanity with openssl.

this is nicer for tracing for sure as http.url is better to scan:

"http.url":"https://kubernetes.default.svc/apis/clux.dev/v1/namespaces/default/foos/good/status?&force=true&fieldManager=cntrlr

@syedriko syedriko mentioned this pull request Jul 9, 2022
Merged
@nightkr nightkr mentioned this pull request Sep 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazk kazk kazk approved these changes

Assignees
No one assigned
Labels
changelog-change changelog change category for prs
Projects
None yet
Milestone
0.72.0
Development

Successfully merging this pull request may close these issues.

In-cluster didn't format correct kube_host_port for IPv6 cluster
2 participants
@clux @kazk