Support lowercase http_proxy & https_proxy evars #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Hey there! Thanks for this. I agree that this is probably good to align - despite lower case evars being a bad style (even google agrees), because it's a fairly common set of evars. However, the DCO must be amended in first. Are you able to address the failing check? |
clux
changed the title
clux
added
changelog-add
Signed-off-by: DevineLiu <hrliu@alauda.io>
|
Now, the DCO passed the check. |
clux
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://cs.opensource.google/go/go/+/master:src/vendor/golang.org/x/net/http/httpproxy/proxy.go;l=27;bpv=1;bpt=1?q=http_proxy&ss=go%2Fgo
proxy_url should be valid when setting env: http_proxy or https_proxy