implement Kubeconfig::from_yaml #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imp
force-pushed
the
kubeconfig-fromstr
branch
from
8f7a84a
to
cbc56ce
Compare
nightkr
reviewed
Nov 18, 2021
kazk
reviewed
Nov 18, 2021
imp
force-pushed
the
kubeconfig-fromstr
branch
2 times, most recently
from
5a24b06
to
efe3a15
Compare
|
Rebased and squashed to clean up the history |
clux
reviewed
Nov 20, 2021
clux
changed the title
Signed-off-by: Cyril Plisko <cyril.plisko@mountall.com>
Signed-off-by: Cyril Plisko <cyril.plisko@mountall.com>
Fixes kube-rs#718 Signed-off-by: Cyril Plisko <cyril.plisko@mountall.com>
Signed-off-by: Cyril Plisko <cyril.plisko@mountall.com>
Signed-off-by: Cyril Plisko <cyril.plisko@mountall.com>
imp
force-pushed
the
kubeconfig-fromstr
branch
from
efe3a15
to
4a34d2d
Compare
clux
reviewed
Nov 20, 2021
clux
approved these changes
Nov 20, 2021
|
Thanks a lot @imp. Minor feature with much back and forth, but useful, and you ended up helping uncover an inconsistency in our parsing logic, so appreciate the time here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #718
Motivation
Allow consumers to load
kubeconfigfrom arbitrary sources with minimal frictionSolution
Refactor code for reading and merging
Kubeconfigyaml documents into the separate public method as well as implementFromStrto make it more idiomatic (I.e. usestr::parse())Kubeconfig::read_fromis updated to use a multi-document reader (kubeconfig_from_yaml) in a separate commit.So if this change would appear to be controversial it could be easily dropped.
Tests are updated to use new functionality as well