Adding more movement keys #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented a min function Added actions for Home, End, PageUp and PageDown Fixes ktr0731#125
ktr0731
requested changes
Jun 7, 2022
fuzzyfinder.go
Outdated
| @@ -415,6 +428,9 @@ func (f *finder) readKey() error { | |||
| f.stateMu.Lock() | |||
| defer f.stateMu.Unlock() | |||
|
|
|||
| // Max number of lines to scroll by using PgUp and PgDn | |||
| const pageScrollBy = 15 | |||
There was a problem hiding this comment.
Could you scroll the list based on the actual screen size?
fuzzyfinder.go
Outdated
| case tcell.KeyPgDn: | ||
| f.state.y -= min(pageScrollBy, f.state.y) | ||
| f.state.cursorY -= min(pageScrollBy, f.state.cursorY) | ||
| case tcell.KeyHome: |
There was a problem hiding this comment.
Since the action of Home in fzf is beginning-of-line, go-fuzzyfinder's one should also be the same behavior.
fuzzyfinder.go
Outdated
| f.state.y = len(f.state.matched) - 1 | ||
| _, height := f.term.Size() | ||
| f.state.cursorY = min(height-3, len(f.state.matched)-1) | ||
| case tcell.KeyEnd: |
There was a problem hiding this comment.
The same as the above comment. This should be the same behavior of end-of-line.
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
- Coverage 85.67% 85.15% -0.53%
==========================================
Files 5 5
Lines 775 795 +20
==========================================
+ Hits 664 677 +13
- Misses 97 104 +7
Partials 14 14 |
|
That should be it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a min function
Added actions for Home, End, PageUp and PageDown
Fixes #125