Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KTOR-5099 Fix memory leak in HttpRequestRetry plugin #3316

Merged
merged 1 commit into from Dec 14, 2022
Merged

KTOR-5099 Fix memory leak in HttpRequestRetry plugin #3316

merged 1 commit into from Dec 14, 2022

Conversation

rsinukov
Copy link
Contributor

@rsinukov rsinukov requested a review from e5l December 13, 2022 20:50
@rsinukov rsinukov self-assigned this Dec 13, 2022
e5l
e5l approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add allocation benchmark to ktor-benchmarks?

@rsinukov rsinukov merged commit 20099e0 into main Dec 14, 2022
@rsinukov rsinukov deleted the rsinukov/retry-memory-leak-fix branch December 14, 2022 11:56
Rattenkrieg pushed a commit to Rattenkrieg/ktor that referenced this pull request Jan 5, 2023
@rsinukov @Rattenkrieg
KTOR-5099 Fix memory leak in HttpRequestRetry plugin (ktorio#3316)
c2f49e8
marychatte pushed a commit that referenced this pull request Jan 10, 2023
@rsinukov @marychatte
KTOR-5099 Fix memory leak in HttpRequestRetry plugin (#3316)
d02c59f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e5l e5l e5l approved these changes

Assignees

@rsinukov rsinukov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rsinukov @e5l