KTOR-5216 Parse header with multiple challenges #3277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marychatte
changed the title
rsinukov
reviewed
Nov 30, 2022
ktor-client/ktor-client-plugins/ktor-client-auth/common/src/io/ktor/client/plugins/auth/Auth.kt
Show resolved
Hide resolved
|
@e5l can you review parsing part, please? |
e5l
requested changes
Dec 1, 2022
ktor-client/ktor-client-plugins/ktor-client-auth/common/src/io/ktor/client/plugins/auth/Auth.kt
Outdated
Show resolved
Hide resolved
marychatte
force-pushed
the
authorization-header-multiple-challenges
branch
from
f7f770b
to
f2b20d6
Compare
marychatte
force-pushed
the
authorization-header-multiple-challenges
branch
from
f2b20d6
to
cfd97b1
Compare
Stexxe
reviewed
Dec 4, 2022
e5l
reviewed
Dec 5, 2022
e5l
reviewed
Dec 5, 2022
marychatte
force-pushed
the
authorization-header-multiple-challenges
branch
from
06cb895
to
0448780
Compare
marychatte
force-pushed
the
authorization-header-multiple-challenges
branch
from
0448780
to
2ad05e2
Compare
rsinukov
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Client
Motivation
Bug: method
parseAuthorizationHeaderdoes not parse multiple challenges and challenges can't be specified in multiple headersSolution
New method
parseAuthorizationHeaders, which can handle more casesAdd parsing of all headers
WWW-Authenticate