Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KTOR-5000 Fix merging nested configs #3212

Merged
merged 1 commit into from Oct 19, 2022
Merged

KTOR-5000 Fix merging nested configs #3212

merged 1 commit into from Oct 19, 2022

Conversation

rsinukov
Copy link
Contributor

@rsinukov rsinukov requested a review from e5l October 18, 2022 15:00
@rsinukov rsinukov self-assigned this Oct 18, 2022
e5l
e5l approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@e5l
Copy link
Member

e5l commented Oct 19, 2022

fast fixed 5000 :D

@rsinukov rsinukov merged commit 3a10900 into main Oct 19, 2022
@rsinukov rsinukov deleted the rsinukov/merge-config-fix branch October 19, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e5l e5l e5l approved these changes

Assignees

@rsinukov rsinukov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rsinukov @e5l