Fix DefaultJson documentation #3021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure about this change. It will break the behaviour of existing clients and we better postpone it to majot release. Maybe it's better to fix documentation to reflect an actual behavior? |
FranAguilarRod
force-pushed
the
ignoreUnknownKeys
branch
from
43b5149
to
dc8ea25
Compare
FranAguilarRod
changed the title
|
I agree, I just update the PR to fix the documentation and also add a test to prove the behavior |
rsinukov
suggested changes
May 25, 2022
| @@ -106,6 +106,17 @@ class JsonSerializationTest : AbstractSerializationTest<Json>() { | |||
| ) | |||
| ) | |||
| } | |||
|
|
|||
| @Test(expected = SerializationException::class) | |||
There was a problem hiding this comment.
Can you please check native tests here? It fails to compile on CI.
Also, we usually use assertFailesWith<SerializationException> { ... } syntax instead
FranAguilarRod
force-pushed
the
ignoreUnknownKeys
branch
from
dc8ea25
to
1a52964
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Client
Motivation
The documentation says that the JSON configuration is "mode is not strict so extra json fields are ignored" but is not what is actually doing.
Solution
Add
ignoreUnknownKeys = trueto make the JSON configuration work as expected.