Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ktor-3854 Fix: separate HttpCookie rendered cookie pairs with space #2938

Merged
merged 3 commits into from Sep 5, 2022

Conversation

john5f35
Copy link
Contributor

@john5f35 john5f35 commented Apr 9, 2022

Subsystem
Client

Motivation
KTOR-3854

Cookie header rendered by HttpCookies should separate cookies with "; " rather than just ";".

Solution
Update renderClientCookies() function to join rendered cookies with "; ".

@rsinukov rsinukov requested a review from e5l August 15, 2022 09:31
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@e5l e5l force-pushed the KTOR-3854-space-separated-cookies branch from 4cfea74 to 34c1f55 Compare August 29, 2022 07:55
@e5l e5l force-pushed the KTOR-3854-space-separated-cookies branch from 34c1f55 to 9bf7d5a Compare August 29, 2022 07:57
@e5l e5l merged commit 08400a5 into ktorio:main Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants