Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.6.8 #2885

Merged
merged 3 commits into from Mar 14, 2022
Merged

Release 1.6.8 #2885

merged 3 commits into from Mar 14, 2022

Conversation

e5l
Copy link
Member

@e5l e5l commented Mar 8, 2022

No description provided.

Copy link
Contributor

@olme04 olme04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like, adopting version catalogs should be a separate PR not coupled with 1.6.8 release :)

gradle/common.gradle Outdated Show resolved Hide resolved
gradle/libs.versions.toml Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
gradle/libs.versions.toml Show resolved Hide resolved
@e5l e5l marked this pull request as ready for review March 10, 2022 08:40
@e5l e5l requested a review from rsinukov March 10, 2022 08:40
Copy link
Contributor

@rsinukov rsinukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but one comment


plugins {
id("kotlinx-serialization")
kotlin("plugin.serialization") version "1.6.10"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you not hardcore the version here and below for serialization?

@e5l e5l merged commit c553697 into 1.6 Mar 14, 2022
@e5l e5l deleted the 1.6.8-eap branch March 14, 2022 07:49
e5l added a commit that referenced this pull request Mar 14, 2022
* Migrate to Gradle Version Catalog

* KTOR-3935 Update versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants