KTOR-2527 using baseName prefix for all metrics #2465
Merged
+36
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsinukov
suggested changes
Oct 22, 2021
| } | ||
|
|
||
| @Test | ||
| fun testUsePreconfiguredRegistry(): Unit = withTestApplication { |
There was a problem hiding this comment.
Hello rsinukov
It is a bad test in my opinion. If I did not miss something, it is a straight copy of "meter is registered for a given path" but with the addition of testRegistry.register("jvm.memory", MemoryUsageGaugeSet()) but it does not test anything extra that the other test already tests.
There was a problem hiding this comment.
This test checks fix for this issue https://youtrack.jetbrains.com/issue/KTOR-1798
There was a problem hiding this comment.
ok, I can put it back but maybe with a better name, "should not throw exception when metric already registered" or something? the old test is not very clear on what it is testing/expecting
lolilofit
pushed a commit
that referenced
this pull request
Nov 3, 2021
e5l
pushed a commit
that referenced
this pull request
Nov 25, 2021
e5l
pushed a commit
that referenced
this pull request
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
server
Motivation
KTOR-2527
#2527
Solution
Prefix all metrics with
baseName. Previously only a small part of the metrics was prefixed.