Skip to content

KTOR-756 Fix exception swallow in html builder #2432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Conversation

e5l
Copy link
Member

@e5l e5l commented Apr 21, 2021

Fix KTOR-756

@e5l e5l requested a review from cy6erGn0m April 21, 2021 08:26
@e5l e5l self-assigned this Apr 21, 2021
it.appendHTML().html(block = builder)
}
} catch (cause: Throwable) {
channel.close(cause)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we already do that on the call side of the writeTo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, but we probably should

@e5l e5l force-pushed the e5l/html-builder-exceptions branch from 87e17b5 to 07a4249 Compare April 23, 2021 12:19
@e5l e5l merged commit 7528790 into main Apr 26, 2021
@e5l e5l deleted the e5l/html-builder-exceptions branch April 26, 2021 07:23
hfhbd pushed a commit to hfhbd/ktor that referenced this pull request Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants