Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove openssl dependency #89

Open
kudlatyamroth opened this issue May 8, 2023 · 6 comments
Open

remove openssl dependency #89

kudlatyamroth opened this issue May 8, 2023 · 6 comments

Comments

@kudlatyamroth
Copy link
Collaborator

Probably only git2 is blocking from switch to rustls
one of alternative would be gitoxide

with openssl there is only problems on cross build...

@jayvdb
Copy link
Collaborator

jayvdb commented Jun 13, 2023

There is already a git2 feature flag, which you can disable to avoid that dependency. Maybe that does the trick for you?

#92 moves all the reqwest stuff into a http feature flag. Is the reqwest default-tls a problem for you? If so, it should be trivial now to add a https flag to allow disabling https, or create a set of tls features to match the various reqwest tls feature flags.

@kudlatyamroth
Copy link
Collaborator Author

if problem is only with reqwest, why not use: rustls-tls

but i think git2 also have some problems here

@kudlatyamroth
Copy link
Collaborator Author

ok, now im sure that git2 has dependency on openssl, and yes we want to use https
but as of now, we cant move to gitoxide as it not support checkout, which is must have here :)

@jayvdb
Copy link
Collaborator

jayvdb commented Dec 14, 2023

for cross-compiling I recommend trying https://github.com/rust-cross/cargo-zigbuild

agree, if you want git2 with https support, openssl is mandatory per https://github.com/rust-lang/git2-rs/blob/master/Cargo.toml#L38C1-L38C62

however, gitoxide does support cloning and it does perform a checkout of the default branch.

Is it really missing the ability to checkout a specified branch?? It appears so, at least on the gix cli: Byron/gitoxide#301

I see gix clone has no -b arg. That is all we need. It seems like the underlying functionality must already exist in gix.

@jayvdb
Copy link
Collaborator

jayvdb commented Dec 14, 2023

Well, even if gix doesnt support checking out a rev, we could support gix checking out the default branch only, which would be what most users want in order to access https://github.com/kstasik/schema-tools-templates .

@kudlatyamroth
Copy link
Collaborator Author

from my point of view, you not always want to use newest version of templates, for example we will switch from version 0.6 schema-tools to 0.16
so if we will use newest templates with 0.6 it would break things that already work
not supporting exact rev, will bring breaking changes when you not make any bit of change in your code :) (like new way of oneOf)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants