Linter for global function names #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
reviewed
Jan 6, 2020
|
changes made! |
nex3
approved these changes
Jan 7, 2020
|
Looks good! |
|
Hmm.. maybe we should generate test cases for each function? If we don't test them then the test coverage will suffer as there will be so many lines that are not tested. |
rambleraptor
force-pushed
the
global-function-names
branch
from
7b1411d
to
1759f36
Compare
|
I had some spare time and put in a whole bunch more test cases. There's more that need to be put in, but this is a lot more than we had earlier. |
kristerkari
approved these changes
Mar 15, 2020
|
I think that this is good now. I need to look through the changes once more before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #397
This creates a linter for global function names.
Couple things:
I didn't know how comprehensive to make the docs + test suite. Putting in examples for every rule seemed excessively verbose.
I purposefully didn't put in auto-fix functionality, since we're encouraging people to use the migrator. Does that seem safe?