Added rule for dollar-variable-first-in-block #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsmunkholm
changed the title
|
I'm really sorry that I have not reviewed this and the other PR yet (been busy). I'll have a look at them when I can. |
|
No worries :) I'm not in a hurry |
|
This looks pretty neat! |
|
Should I give up on this? 😅 |
kristerkari
approved these changes
Mar 19, 2020
No! Sorry that it took me so long :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
dollar-variable-first-in-blockrule that checks if variables are put first in a block (root and rules).It can be set to ignore comments and imports, and make exceptions when variables are placed in root or inside an at-rule, function, mixin, if/else or for/each/while-loops.
This is my first contribution to
stylelint-scss... Please don't hesitate to let me know, if I'm doing anything wrong :)