Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error reporting for dimension-no-non-numeric-values #365

Merged
merged 1 commit into from Sep 6, 2019
Merged

Fix error reporting for dimension-no-non-numeric-values #365

merged 1 commit into from Sep 6, 2019

Conversation

kristerkari
Copy link
Collaborator

Fix following issues related to the dimension-no-non-numeric-values rule:

  • Rejected message was throwing an error because it was called without the unit.
  • Change highlighted error to point to the unit that is used with the interpolation, instead of it pointing to the property name. That makes much more sense if you are using this rule with CSS shorthand properties.

Fixes #363

Please review @rambleraptor @fuhlig

@kristerkari
Copy link
Collaborator Author

Skärmavbild 2019-09-05 kl 21 16 11

@kristerkari kristerkari mentioned this pull request Sep 5, 2019
Closed
@kristerkari kristerkari merged commit 964dd90 into master Sep 6, 2019
@kristerkari kristerkari deleted the bugfix/dimension-no-non-numeric-values branch September 6, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rambleraptor rambleraptor rambleraptor approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dimension-no-non-numeric-values throws error
2 participants
@kristerkari @rambleraptor