New rule: at-if-no-null
#344
Conversation
| }`, | ||
| description: "does not use the == null format" | ||
| } | ||
| ], |
There was a problem hiding this comment.
There could be some more tests with calculations and other conditions inside @if to make sure that there are no false positives/negatives.
There was a problem hiding this comment.
@nex3 any ideas on good tests or language constructs that users might be using in these if/else statements?
There was a problem hiding this comment.
When I'm looking for realistic examples, I often look through big open-source corpuses like https://github.com/angular/components/tree/master/src/material or https://github.com/carbon-design-system/carbon/tree/master/packages.
There was a problem hiding this comment.
Great idea! I didn't know of any large Sass codebases.
I grepped through carbon-design and came across a common pattern (if $x != null and expr). I made adjustments to the rule for that pattern.
rambleraptor
force-pushed
the
at-if-no-null
branch
from
f2fd9f9
to
3f3919a
Compare
The sass/linter project had a rule to check for using
== nullor!= nullinside @if statements.This rule replicates that.