Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stylelint-config-recommended to 5.0 #81

Merged
merged 1 commit into from Jul 8, 2021

Conversation

kristerkari
Copy link
Collaborator

Closes #67

@kristerkari kristerkari merged commit c703ac7 into master Jul 8, 2021
@kristerkari kristerkari deleted the update-stylelint-config-recommended branch July 8, 2021 19:44
@kellyselden
Copy link

Wouldn't bumping this breaking change make your package also a breaking change instead of a minor release?

@kristerkari
Copy link
Collaborator Author

Yeah, I should have probably used a major version number instead of a minor one. I did not really pay enough attention.

@kellyselden
Copy link

We noticed the minor version breaking our linting. Are you planning to revert or leave as-is?

@kristerkari
Copy link
Collaborator Author

hmm.. I mean I can try to revert the minor and release it as major version instead, but I'm not sure how to do that without messing things up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants