Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change defaults to ignoreLocation: true and ignoreFieldNorm: true #753

Closed
1 task done
ViktorQvarfordt opened this issue Dec 28, 2023 · 2 comments
Closed
1 task done

Comments

@ViktorQvarfordt
Copy link

Is there an existing issue or pull request for this?

  • I have searched the existing issues and pull requests

Feature description

The default is ignoreLocation: false and ignoreFieldNorm: false, this causes basic searches to give very strange results.

Desired solution

Set the default options to ignoreLocation: true and ignoreFieldNorm: true.

Alternatives considered

Make it very clear early in the docs or in the demo that one might want to use these options. I was so close to giving up on this library until I found these options. I just plainly want to fuzzy-search for matches in my strings. I don't expect any location or string length to affect the search by default.

Additional context

No response

@leeoniya
Copy link

leeoniya commented Dec 28, 2023

ignoreFieldNorm: true

nice, this is one i missed in my comparison [1] that definitely improves Fuse's fuzzy results [2].
(added this change in leeoniya/uFuzzy@ec1c44b)

[1] https://github.com/leeoniya/uFuzzy?tab=readme-ov-file#a-biased-appraisal-of-similar-work
[2] https://leeoniya.github.io/uFuzzy/demos/compare.html?libs=uFuzzy,fuzzysort,QuickScore,Fuse&search=super%20ma

Copy link

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 30 days

@github-actions github-actions bot added the Stale label Apr 27, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants