fix & enhance type definition of search() #318
Merged
+52
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript Playground Links: Current version / PR version
fuse.search
should returnstring[]
with option includesid
Current:
PR:
score: number | undefined
is troublesome to handle with--strictNullChecks
Current:
PR:
with no-literal option object, TS cannot infer type of return of
search()
(#303)Current:
this is not fixed, but now type inference can be overridden
PR:
248ee31 is not working
Current:
PR: