Skip to content
This repository has been archived by the owner on Jan 25, 2020. It is now read-only.

Bump graceful-fs dependency #46

Open
ChALkeR opened this issue Feb 13, 2016 · 2 comments
Open

Bump graceful-fs dependency #46

ChALkeR opened this issue Feb 13, 2016 · 2 comments

Comments

@ChALkeR
Copy link

ChALkeR commented Feb 13, 2016

graceful-fs versions lower than v4 reevaluate native fs module source, which is not supported.
You should update your graceful-fs dependency to v4 or later.

Tracking issue: nodejs/node#5213.

thefourtheye added a commit to thefourtheye/engine-munger that referenced this issue Feb 13, 2016
@ChALkeR
Copy link
Author

ChALkeR commented Jul 21, 2016

Hi. engine-munger is currently #34 in my list of modules that would likely to be broken when nodejs/node#6413 lands (which is anticipated to happen before v7.0).

Note that graceful-fs@1 and graceful-fs@4 are ok and would not be broken by this, but a require() on graceful-fs@2 or graceful-fs@3 would cause an error soon.

That is, runtime warning fs: re-evaluating native module sources is not supported. would be turned into a throw.

If you or your deps use graceful-fs@2 or graceful-fs@3 in runtime — you are affected.

This doesn't look to be fixed in the latest version, because file-resolver@1.0.2 depends on graceful-fs@2.0.3.

Tracking: nodejs/node#5213.

/cc @aredridel @grawk.

@ChALkeR
Copy link
Author

ChALkeR commented Jul 21, 2016

Related: krakenjs/file-resolver#31.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant