diff: detect cycles in the values being compared. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents infinite recursion, similar to the fixes to the formatter in kr#13. In addition to detecting cycles, we also check that the two values contain the same cyclic structure.
|
@kr: any chance of having this reviewed and/or merged? |
kr
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents infinite recursion, similar to the fixes to the formatter in #13. In addition to detecting cycles, we also check that the two values contain the same cyclic structure.
The idea is that if a value contains cycles or multiple ways of visiting a sub-value, then that is important to the underlying structure of the value (e.g. a type representing a DAG, or or trees with back pointers to their parent nodes).