Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast image resize #57

Open
edgarriba opened this issue Mar 17, 2024 · 3 comments
Open

fast image resize #57

edgarriba opened this issue Mar 17, 2024 · 3 comments

Comments

@edgarriba
Copy link
Member

Explore this crate and benchmark: https://docs.rs/fast_image_resize/latest/fast_image_resize/index.html

@ternaus
Copy link

ternaus commented Mar 18, 2024

Darwin Vladimirs-MacBook-Pro.local 23.2.0 Darwin Kernel Version 23.2.0: Wed Nov 15 21:53:18 PST 2023; root:xnu-10002.61.3~2/RELEASE_ARM64_T6000 arm64
kornia_rs==0.1.2
numpy==1.26.4
opencv-python-headless==4.9.0.80
pillow==10.2.0
python py-kornia/benchmark/bench_resize.py
OpenCV: 0.04 ms
PIL: 0.20 ms
Kornia: 0.17 ms

I believe that the benchmark should run over many different images.

This setup could be a bit too extensive, but still....
https://github.com/ternaus/imread_benchmark/blob/main/imread_benchmark/benchmark.py

@edgarriba
Copy link
Member Author

I think this benchmarks should be running in a Linux machine which I guess is the most typical scenario for training. Besides, why don’t you use timeit which run several iterations and remove any possible outlier plus other things for you. Also, the benchmark should really be done against a data loader routine and measure probably IPS (images per second)

@ternaus
Copy link

ternaus commented Mar 19, 2024

Just run your code from https://github.com/kornia/kornia-rs/blob/main/py-kornia/benchmark/bench_resize.py

Would be happy to check a version with an updated setup for a benchmark :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants