Skip to content
This repository has been archived by the owner on Jul 8, 2022. It is now read-only.

Add linux based android SDK locations to gradle #497

Merged
merged 4 commits into from
Mar 18, 2022

Conversation

jobe-m
Copy link
Contributor

@jobe-m jobe-m commented Mar 18, 2022

No description provided.

@jobe-m jobe-m requested a review from soywiz March 18, 2022 12:17
build.gradle.kts Outdated
"$userHome/AndroidSDK", // location of sdkmanager on linux
"/usr/lib/android-sdk", // location on debian based linux (sudo apt install android-sdk)
"/Library/Android/sdk/", // some other flavor of linux
"/Users/$userHome/Library/Android/sdk"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be either /Users/$userName or $userHome, right? Because userHome is already the absolute path in the filesysten

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, right :)

Copy link
Contributor

@soywiz soywiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jobe-m
Copy link
Contributor Author

jobe-m commented Mar 18, 2022

Ok, now I guess it should be ok :)

Copy link
Contributor

@soywiz soywiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) feel free to merge it

@jobe-m jobe-m merged commit e4ddebd into main Mar 18, 2022
@jobe-m jobe-m deleted the feature/Update_guess_Android_SDK_location branch March 18, 2022 16:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants