Skip to content
This repository has been archived by the owner on Jul 8, 2022. It is now read-only.

View extension method for scaling view by maintaining aspecg ratio. #448

Merged
merged 4 commits into from
Mar 13, 2022
Merged

View extension method for scaling view by maintaining aspecg ratio. #448

merged 4 commits into from
Mar 13, 2022

Conversation

Kietyo
Copy link
Contributor

@Kietyo Kietyo commented Mar 2, 2022

No description provided.

soywiz
soywiz reviewed Mar 9, 2022
View reviewed changes
korim/src/commonMain/kotlin/com/soywiz/korim/color/MaterialColors.kt Outdated
package com.soywiz.korim.color

// https://material.io/design/color/the-color-system.html#tools-for-picking-colors
object MaterialColors {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this from another PR?

soywiz
soywiz approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@soywiz soywiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove MaterialColors first from the PR?

@Kietyo
Copy link
Contributor Author

Kietyo commented Mar 10, 2022

Not sure how. Shouldn't be an issue though.

@Kietyo
Copy link
Contributor Author

Kietyo commented Mar 10, 2022

Ok seems like I fixed it somehow.

@soywiz soywiz merged commit 771b8ee into korlibs-archive:main Mar 13, 2022
@soywiz
Copy link
Contributor

soywiz commented Mar 13, 2022

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@soywiz soywiz soywiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kietyo @soywiz