improve debugger #442
improve debugger #442
Conversation
…is will hopefully help to make the debug font more readable on height resolutions with small displays.
|
|
||
| fun addDebugRenderer(block: Views.(RenderContext) -> Unit) { | ||
| fun addDebugRenderer(block: Views.(RenderContext, Double) -> Unit) { |
There was a problem hiding this comment.
Instead of passing it as a primitive as an extra argument, can we put this extraFontScale inside the RenderContext? Either as a property or as an extrinsic Extra.Property? Maybe with a name like debugExtraFontScale or something?
Additionally, are you doing this because we are not properly detecting the device pixel ratio on windows? Could we implement that instead?
|
Hey @soywiz I did you requestet change and insertet the debugExtraFontScale into the RendererContext. Maybe you are right and it would be a better idea to implement the device pixel ratio correctly but maybe for someone the font is still to small so it is possible to make the font bigger (or smaller). |
|
ok now we use the scaling settings too. |
…value while it is running...
|
Awesome! Thanks :) let's wait for CI to finish |
| // somehow this value is not update when you change the scaling in the windows settings while the jvm is running :( | ||
| val pixelsPerLogicalInchRatio = Toolkit.getDefaultToolkit().screenResolution / defaultPixelsPerLogicalInch | ||
|
|
||
| return@lazy (scale * pixelsPerLogicalInchRatio) |
There was a problem hiding this comment.
Tested on mac. On mac, it should be something like scale / pixelsPerLogicalInchRatio.
But I believe we should separate those values:
override val devicePixelRatio: Double get() = ... scaleX
override val pixelsPerLogicalInchRatio: Double get() = ... screenResolution / defaultPixelsPerLogicalInch
// Use this in the debug handler, while allowing people to access raw devicePixelRatio without the noise of window scaling
override val computedPixelRatio: Double get() = devicePixelRatio / pixelsPerLogicalInchRatio
Otherwise devicePixelRatio stops being true. Is it 1 on your hdpi screen? On mac devices with retina displays it is 2, without it, it is 1.
There was a problem hiding this comment.
The "scale" value on my windows laptop is always 1 so the multiplication was just an assumption
There was a problem hiding this comment.
But yes we can separate the values.
There was a problem hiding this comment.
i'm still not sure about the calculation of "computedPixelRatio" becasue in my opinion it must be
devicePixelRatio * pixelsPerLogicalInchRatio
or
pixelsPerLogicalInchRatio / devicePixelRatio
bognari
changed the title
|
@soywiz any feedback about my pr? |
|
Yes, sorry for the delay. Had a pretty long couple of weeks, and forgot to check this. Im not at home right now, but Ill check it asap |
|
sorry. all is good. take your time. this was just a reminder |
| @@ -46,6 +46,8 @@ class RenderContext constructor( | |||
| val views: Views? = bp as? Views? | |||
|
|
|||
| var debugAnnotateView: View? = null | |||
| var debugExtraFontScale : Double = 1.0 | |||
| var debugExtraFontColor : RGBA = Colors.WHITE | |||
There was a problem hiding this comment.
Downloaded the PR, and this line seems to fail because RGBA is not found.
You should add a import com.soywiz.korim.color.*
|
Thanks! |
This will hopefully help to make the debug font more readable on height resolutions with small displays.
partial fix / workaround for korlibs/korge#556