New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logic problem in types.is_optional? #161
Labels
bug
Something isn't working
Comments
Hi @joseph-long - thank you for reporting this issue. It looks like a bug, probably same issue as #163. I hope I will fix it soon. |
I've come across similar issue with
didn't get
did. |
@joseph-long hope it's fixed via #164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was wondering why my optional union wasn't matching, and instead raising an exception from a type hook trying to convert a string into a float... and after some investigation I think it's this line:
https://github.com/konradhalas/dacite/blob/master/dacite/types.py#L48
Changing the implementation to
makes things work, and
from_dict
takes the_build_value
path instead. (At least, I think so, if I'm following it correctly!)Thanks for building this and sharing it. I apologize for not including a minimal reproducing example now, but it's late here and I wanted to write things down while they are in my head 🙃
The text was updated successfully, but these errors were encountered: