Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom framing for UDP #77

Open
Bathtor opened this issue Jul 24, 2020 · 1 comment
Open

Custom framing for UDP #77

Bathtor opened this issue Jul 24, 2020 · 1 comment
Assignees
Milestone

Comments

@Bathtor
Copy link
Contributor

Bathtor commented Jul 24, 2020

Currently (as of #75 ) UDP uses the same framing header as TCP packets, even though much of it is unused on the UDP path.

While it is easier for maintenance to keep the the same, it does waste between 9 and 4 bytes (depending on what we want to keep) of previous space in a UDP packet.

This issue should be considered a reminder to re-evaluate UDP framing in the future.

@adamhass adamhass self-assigned this Mar 5, 2021
@adamhass
Copy link
Collaborator

adamhass commented Mar 5, 2021

Move frame-headers to be handled entirely by the NetworkThread.

@adamhass adamhass added this to the 1.0.0 milestone Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants