forked from rubocop/rubocop
/
redundant_file_extension_in_require.rb
52 lines (46 loc) · 1.63 KB
/
redundant_file_extension_in_require.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
# frozen_string_literal: true
module RuboCop
module Cop
module Style
# This cop checks for the presence of superfluous `.rb` extension in
# the filename provided to `require` and `require_relative`.
#
# Note: If the extension is omitted, Ruby tries adding '.rb', '.so',
# and so on to the name until found. If the file named cannot be found,
# a `LoadError` will be raised.
# There is an edge case where `foo.so` file is loaded instead of a `LoadError`
# if `foo.so` file exists when `require 'foo.rb'` will be changed to `require 'foo'`,
# but that seems harmless.
#
# @example
# # bad
# require 'foo.rb'
# require_relative '../foo.rb'
#
# # good
# require 'foo'
# require 'foo.so'
# require_relative '../foo'
# require_relative '../foo.so'
#
class RedundantFileExtensionInRequire < Base
extend AutoCorrector
MSG = 'Redundant `.rb` file extension detected.'
RESTRICT_ON_SEND = %i[require require_relative].freeze
# @!method require_call?(node)
def_node_matcher :require_call?, <<~PATTERN
(send nil? {:require :require_relative} $str_type?)
PATTERN
def on_send(node)
require_call?(node) do |name_node|
return unless name_node.value.end_with?('.rb')
add_offense(name_node) do |corrector|
correction = name_node.value.delete_suffix('.rb')
corrector.replace(name_node, "'#{correction}'")
end
end
end
end
end
end
end