forked from rubocop/rubocop
/
multiple_comparison_spec.rb
200 lines (176 loc) · 4.9 KB
/
multiple_comparison_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::MultipleComparison, :config do
subject(:cop) { described_class.new(config) }
it 'does not register an offense for comparing an lvar' do
expect_no_offenses(<<~RUBY)
a = "a"
if a == "a"
print a
end
RUBY
end
it 'registers an offense and corrects when `a` is compared twice' do
expect_offense(<<~RUBY)
a = "a"
if a == "a" || a == "b"
^^^^^^^^^^^^^^^^^^^^ Avoid comparing a variable with multiple items in a conditional, use `Array#include?` instead.
print a
end
RUBY
expect_correction(<<~RUBY)
a = "a"
if ["a", "b"].include?(a)
print a
end
RUBY
end
it 'registers an offense and corrects when `a` is compared three times' do
expect_offense(<<~RUBY)
a = "a"
if a == "a" || a == "b" || a == "c"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Avoid comparing a variable with multiple items in a conditional, use `Array#include?` instead.
print a
end
RUBY
expect_correction(<<~RUBY)
a = "a"
if ["a", "b", "c"].include?(a)
print a
end
RUBY
end
it 'registers an offense and corrects when `a` is compared three times on the right ' \
'hand side' do
expect_offense(<<~RUBY)
a = "a"
if "a" == a || "b" == a || "c" == a
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Avoid comparing a variable with multiple items in a conditional, use `Array#include?` instead.
print a
end
RUBY
expect_correction(<<~RUBY)
a = "a"
if ["a", "b", "c"].include?(a)
print a
end
RUBY
end
it 'registers an offense and corrects when `a` is compared three times, once on the ' \
'righthand side' do
expect_offense(<<~RUBY)
a = "a"
if a == "a" || "b" == a || a == "c"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Avoid comparing a variable with multiple items in a conditional, use `Array#include?` instead.
print a
end
RUBY
expect_correction(<<~RUBY)
a = "a"
if ["a", "b", "c"].include?(a)
print a
end
RUBY
end
it 'registers an offense and corrects when multiple comparison is not ' \
'part of a conditional' do
expect_offense(<<~RUBY)
def foo(x)
x == 1 || x == 2 || x == 3
^^^^^^^^^^^^^^^^^^^^^^^^^^ Avoid comparing a variable with multiple items in a conditional, use `Array#include?` instead.
end
RUBY
expect_correction(<<~RUBY)
def foo(x)
[1, 2, 3].include?(x)
end
RUBY
end
it 'does not register an offense for comparing multiple literal strings' do
expect_no_offenses(<<~RUBY)
if "a" == "a" || "a" == "c"
print "a"
end
RUBY
end
it 'does not register an offense for comparing multiple int literals' do
expect_no_offenses(<<~RUBY)
if 1 == 1 || 1 == 2
print 1
end
RUBY
end
it 'does not register an offense for comparing lvars' do
expect_no_offenses(<<~RUBY)
a = "a"
b = "b"
if a == "a" || b == "b"
print a
end
RUBY
end
it 'does not register an offense for comparing lvars when a string is ' \
'on the lefthand side' do
expect_no_offenses(<<~RUBY)
a = "a"
b = "b"
if a == "a" || "b" == b
print a
end
RUBY
end
it 'does not register an offense for a == b || b == a' do
expect_no_offenses(<<~RUBY)
a = "a"
b = "b"
if a == b || b == a
print a
end
RUBY
end
it 'does not register an offense for a duplicated condition' do
expect_no_offenses(<<~RUBY)
a = "a"
b = "b"
if a == b || a == b
print a
end
RUBY
end
it 'does not register an offense for Array#include?' do
expect_no_offenses(<<~RUBY)
a = "a"
if ["a", "b", "c"].include? a
print a
end
RUBY
end
context 'when `AllowMethodComparison: true`' do
let(:cop_config) { { 'AllowMethodComparison' => true } }
it 'does not register an offense when using multiple method calls' do
expect_no_offenses(<<~RUBY)
col = loc.column
if col == before.column || col == after.column
do_something
end
RUBY
end
end
context 'when `AllowMethodComparison: false`' do
let(:cop_config) { { 'AllowMethodComparison' => false } }
it 'registers an offense and corrects when using multiple method calls' do
expect_offense(<<~RUBY)
col = loc.column
if col == before.column || col == after.column
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Avoid comparing a variable with multiple items in a conditional, use `Array#include?` instead.
do_something
end
RUBY
expect_correction(<<~RUBY)
col = loc.column
if [before.column, after.column].include?(col)
do_something
end
RUBY
end
end
end