forked from rubocop/rubocop
/
hash_except_spec.rb
174 lines (145 loc) · 5.67 KB
/
hash_except_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::HashExcept, :config do
context 'Ruby 3.0 or higher', :ruby30 do
it 'registers and corrects an offense when using `reject` and comparing with `lvar == :sym`' do
expect_offense(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.reject { |k, v| k == :bar }
^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `except(:bar)` instead.
RUBY
expect_correction(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.except(:bar)
RUBY
end
it 'registers and corrects an offense when using `reject` and comparing with `:sym == lvar`' do
expect_offense(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.reject { |k, v| :bar == k }
^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `except(:bar)` instead.
RUBY
expect_correction(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.except(:bar)
RUBY
end
it 'registers and corrects an offense when using `select` and comparing with `lvar != :sym`' do
expect_offense(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.select { |k, v| k != :bar }
^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `except(:bar)` instead.
RUBY
expect_correction(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.except(:bar)
RUBY
end
it 'registers and corrects an offense when using `select` and comparing with `:sym != lvar`' do
expect_offense(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.select { |k, v| :bar != k }
^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `except(:bar)` instead.
RUBY
expect_correction(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.except(:bar)
RUBY
end
it "registers and corrects an offense when using `reject` and comparing with `lvar == 'str'`" do
expect_offense(<<~RUBY)
hash.reject { |k, v| k == 'str' }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `except('str')` instead.
RUBY
expect_correction(<<~RUBY)
hash.except('str')
RUBY
end
it 'registers and corrects an offense when using `reject` and other than comparison by string and symbol using `eql?`' do
expect_offense(<<~RUBY)
hash.reject { |k, v| k.eql?(0.0) }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `except(0.0)` instead.
RUBY
expect_correction(<<~RUBY)
hash.except(0.0)
RUBY
end
it 'registers and corrects an offense when using `filter` and comparing with `lvar != :sym`' do
expect_offense(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.filter { |k, v| k != :bar }
^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `except(:bar)` instead.
RUBY
expect_correction(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.except(:bar)
RUBY
end
it 'does not register an offense when using `reject` and other than comparison by string and symbol using `==`' do
expect_no_offenses(<<~RUBY)
hash.reject { |k, v| k == 0.0 }
RUBY
end
it 'does not register an offense when using `delete_if` and comparing with `lvar == :sym`' do
expect_no_offenses(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.delete_if { |k, v| k == :bar }
RUBY
end
it 'does not register an offense when using `keep_if` and comparing with `lvar != :sym`' do
expect_no_offenses(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.keep_if { |k, v| k != :bar }
RUBY
end
it 'does not register an offense when comparing with hash value' do
expect_no_offenses(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.reject { |k, v| v.eql? :bar }
RUBY
end
end
context 'Ruby 2.7 or lower', :ruby27 do
it 'does not register an offense when using `reject` and comparing with `lvar == :key`' do
expect_no_offenses(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.reject { |k, v| k == :bar }
RUBY
end
it 'does not register an offense when using `reject` and comparing with `:key == lvar`' do
expect_no_offenses(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.reject { |k, v| :bar == k }
RUBY
end
it 'does not register an offense when using `select` and comparing with `lvar != :key`' do
expect_no_offenses(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.select { |k, v| k != :bar }
RUBY
end
it 'does not register an offense when using `select` and comparing with `:key != lvar`' do
expect_no_offenses(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.select { |k, v| :bar != k }
RUBY
end
end
it 'does not register an offense when using `reject` and comparing with `lvar != :key`' do
expect_no_offenses(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.reject { |k, v| k != :bar }
RUBY
end
it 'does not register an offense when using `reject` and comparing with `:key != lvar`' do
expect_no_offenses(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.reject { |k, v| :bar != key }
RUBY
end
it 'does not register an offense when using `select` and comparing with `lvar == :key`' do
expect_no_offenses(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.select { |k, v| k == :bar }
RUBY
end
it 'does not register an offense when using `select` and comparing with `:key == lvar`' do
expect_no_offenses(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.select { |k, v| :bar == key }
RUBY
end
it 'does not register an offense when not using key block argument`' do
expect_no_offenses(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.reject { |k, v| do_something != :bar }
RUBY
end
it 'does not register an offense when not using block`' do
expect_no_offenses(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.reject
RUBY
end
it 'does not register an offense when using `Hash#except`' do
expect_no_offenses(<<~RUBY)
{foo: 1, bar: 2, baz: 3}.except(:bar)
RUBY
end
end