forked from rubocop/rubocop
/
double_negation_spec.rb
259 lines (230 loc) · 5.59 KB
/
double_negation_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::DoubleNegation, :config do
let(:cop_config) { { 'EnforcedStyle' => enforced_style } }
shared_examples 'common' do
it 'registers an offense and corrects for `!!` when not a return location' do
expect_offense(<<~RUBY)
def foo?
foo
!!test.something
^ Avoid the use of double negation (`!!`).
bar
end
RUBY
expect_correction(<<~RUBY)
def foo?
foo
!test.something.nil?
bar
end
RUBY
end
it 'registers an offense and corrects for `!!`' do
expect_offense(<<~RUBY)
!!test.something
^ Avoid the use of double negation (`!!`).
RUBY
expect_correction(<<~RUBY)
!test.something.nil?
RUBY
end
it 'does not register an offense for !' do
expect_no_offenses('!test.something')
end
it 'does not register an offense for `not not`' do
expect_no_offenses('not not test.something')
end
end
context 'when `EnforcedStyle: allowed_in_returns`' do
let(:enforced_style) { 'allowed_in_returns' }
include_examples 'common'
it 'does not register an offense for `!!` when return location' do
expect_no_offenses(<<~RUBY)
def foo?
bar
!!baz.do_something
end
RUBY
end
it 'does not register an offense for `!!` when using `return` keyword' do
expect_no_offenses(<<~RUBY)
def foo?
return !!bar.do_something if condition
baz
!!qux
end
RUBY
end
it 'does not register an offense for `!!` when return location and using `rescue`' do
expect_no_offenses(<<~RUBY)
def foo?
bar
!!baz.do_something
rescue
qux
end
RUBY
end
it 'does not register an offense for `!!` when return location and using `ensure`' do
expect_no_offenses(<<~RUBY)
def foo?
bar
!!baz.do_something
ensure
qux
end
RUBY
end
it 'does not register an offense for `!!` when return location and using `rescue` and `ensure`' do
expect_no_offenses(<<~RUBY)
def foo?
bar
!!baz.do_something
rescue
qux
ensure
corge
end
RUBY
end
it 'does not register an offense for `!!` when return location and using `rescue`, `else`, and `ensure`' do
expect_no_offenses(<<~RUBY)
def foo?
bar
!!baz.do_something
rescue
qux
else
quux
ensure
corge
end
RUBY
end
end
context 'when `EnforcedStyle: forbidden`' do
let(:enforced_style) { 'forbidden' }
include_examples 'common'
it 'registers an offense and corrects for `!!` when return location' do
expect_offense(<<~RUBY)
def foo?
bar
!!baz.do_something
^ Avoid the use of double negation (`!!`).
end
RUBY
expect_correction(<<~RUBY)
def foo?
bar
!baz.do_something.nil?
end
RUBY
end
it 'registers an offense and corrects for `!!` when using `return` keyword' do
expect_offense(<<~RUBY)
def foo?
return !!bar.do_something if condition
^ Avoid the use of double negation (`!!`).
baz
!!bar
^ Avoid the use of double negation (`!!`).
end
RUBY
expect_correction(<<~RUBY)
def foo?
return !bar.do_something.nil? if condition
baz
!bar.nil?
end
RUBY
end
it 'registers an offense for `!!` when return location and using `rescue`' do
expect_offense(<<~RUBY)
def foo?
bar
!!baz.do_something
^ Avoid the use of double negation (`!!`).
rescue
qux
end
RUBY
expect_correction(<<~RUBY)
def foo?
bar
!baz.do_something.nil?
rescue
qux
end
RUBY
end
it 'registers an offense for `!!` when return location and using `ensure`' do
expect_offense(<<~RUBY)
def foo?
bar
!!baz.do_something
^ Avoid the use of double negation (`!!`).
ensure
qux
end
RUBY
expect_correction(<<~RUBY)
def foo?
bar
!baz.do_something.nil?
ensure
qux
end
RUBY
end
it 'registers an offense for `!!` when return location and using `rescue` and `ensure`' do
expect_offense(<<~RUBY)
def foo?
bar
!!baz.do_something
^ Avoid the use of double negation (`!!`).
rescue
baz
ensure
qux
end
RUBY
expect_correction(<<~RUBY)
def foo?
bar
!baz.do_something.nil?
rescue
baz
ensure
qux
end
RUBY
end
it 'registers an offense for `!!` when return location and using `rescue`, `else`, and `ensure`' do
expect_offense(<<~RUBY)
def foo?
bar
!!baz.do_something
^ Avoid the use of double negation (`!!`).
rescue
qux
else
quux
ensure
corge
end
RUBY
expect_correction(<<~RUBY)
def foo?
bar
!baz.do_something.nil?
rescue
qux
else
quux
ensure
corge
end
RUBY
end
end
end