forked from rubocop/rubocop
/
redundant_condition_spec.rb
367 lines (319 loc) · 8.3 KB
/
redundant_condition_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::RedundantCondition do
subject(:cop) { described_class.new }
context 'when regular condition (if)' do
it 'accepts different when the condition does not match the branch' do
expect_no_offenses(<<~RUBY)
if a
b
else
c
end
RUBY
end
it 'accepts elsif' do
expect_no_offenses(<<~RUBY)
if a
b
elsif d
d
else
c
end
RUBY
end
context 'when condition and if_branch are same' do
it 'registers an offense and corrects' do
expect_offense(<<~RUBY)
if b
^^^^ Use double pipes `||` instead.
b
else
c
end
RUBY
expect_correction(<<~RUBY)
b || c
RUBY
end
it 'registers an offense and corrects when using assignment by hash key access' do
expect_no_offenses(<<~RUBY)
if @cache[key]
@cache[key]
else
@cache[key] = heavy_load[key]
end
RUBY
end
it 'registers an offense and corrects when `raise` without argument parentheses in `else`' do
expect_offense(<<~RUBY)
if b
^^^^ Use double pipes `||` instead.
b
else
raise 'foo'
end
RUBY
expect_correction(<<~RUBY)
b || raise('foo')
RUBY
end
it 'registers an offense and corrects when a method without argument parentheses in `else`' do
expect_offense(<<~RUBY)
if b
^^^^ Use double pipes `||` instead.
b
else
do_something foo, bar, key: :value
end
RUBY
expect_correction(<<~RUBY)
b || do_something(foo, bar, key: :value)
RUBY
end
it 'registers an offense and corrects complex one liners' do
expect_offense(<<~RUBY)
if b
^^^^ Use double pipes `||` instead.
b
else
(c || d)
end
RUBY
expect_correction(<<~RUBY)
b || (c || d)
RUBY
end
it 'registers an offense and corrects modifier nodes offense' do
expect_offense(<<~RUBY)
if b
^^^^ Use double pipes `||` instead.
b
else
c while d
end
RUBY
expect_correction(<<~RUBY)
b || (c while d)
RUBY
end
it 'registers an offense and corrects multiline nodes' do
expect_offense(<<~RUBY)
if b
^^^^ Use double pipes `||` instead.
b
else
y(x,
z)
end
RUBY
expect_correction(<<~RUBY)
b || y(x,
z)
RUBY
end
it 'auto-corrects when using `<<` method higher precedence ' \
'than `||` operator' do
expect_offense(<<~RUBY)
ary << if foo
^^^^^^ Use double pipes `||` instead.
foo
else
bar
end
RUBY
expect_correction(<<~RUBY)
ary << (foo || bar)
RUBY
end
it 'accepts complex else branches' do
expect_no_offenses(<<~RUBY)
if b
b
else
c
d
end
RUBY
end
it 'accepts an elsif branch' do
expect_no_offenses(<<~RUBY)
if a
a
elsif cond
d
end
RUBY
end
it 'registers an offense and corrects when using modifier if' do
expect_offense(<<~RUBY)
bar if bar
^^^^^^^^^^ This condition is not needed.
RUBY
expect_correction(<<~RUBY)
bar
RUBY
end
it 'registers an offense and corrects when `if` condition and `then` ' \
'branch are the same and it has no `else` branch' do
expect_offense(<<~RUBY)
if do_something
^^^^^^^^^^^^^^^ This condition is not needed.
do_something
end
RUBY
expect_correction(<<~RUBY)
do_something
RUBY
end
it 'accepts when using ternary if in `else` branch' do
expect_no_offenses(<<~RUBY)
if a
a
else
b ? c : d
end
RUBY
end
it 'registers an offense and corrects when the else branch ' \
'contains an irange' do
expect_offense(<<~RUBY)
if foo
^^^^^^ Use double pipes `||` instead.
foo
else
1..2
end
RUBY
expect_correction(<<~RUBY)
foo || (1..2)
RUBY
end
end
end
context 'ternary expression (?:)' do
it 'accepts expressions when the condition and if branch do not match' do
expect_no_offenses('b ? d : c')
end
context 'when condition and if_branch are same' do
it 'registers an offense and corrects' do
expect_offense(<<~RUBY)
b ? b : c
^^^^^ Use double pipes `||` instead.
RUBY
expect_correction(<<~RUBY)
b || c
RUBY
end
it 'registers an offense and corrects nested vars' do
expect_offense(<<~RUBY)
b.x ? b.x : c
^^^^^^^ Use double pipes `||` instead.
RUBY
expect_correction(<<~RUBY)
b.x || c
RUBY
end
it 'registers an offense and corrects class vars' do
expect_offense(<<~RUBY)
@b ? @b : c
^^^^^^ Use double pipes `||` instead.
RUBY
expect_correction(<<~RUBY)
@b || c
RUBY
end
it 'registers an offense and corrects functions' do
expect_offense(<<~RUBY)
a = b(x) ? b(x) : c
^^^^^^^^ Use double pipes `||` instead.
RUBY
expect_correction(<<~RUBY)
a = b(x) || c
RUBY
end
it 'registers an offense and corrects when the else branch ' \
'contains an irange' do
expect_offense(<<~RUBY)
time_period = updated_during ? updated_during : 2.days.ago..Time.now
^^^^^^^^^^^^^^^^^^ Use double pipes `||` instead.
RUBY
expect_correction(<<~RUBY)
time_period = updated_during || (2.days.ago..Time.now)
RUBY
end
it 'registers an offense and corrects when the else branch ' \
'contains an erange' do
expect_offense(<<~RUBY)
time_period = updated_during ? updated_during : 2.days.ago...Time.now
^^^^^^^^^^^^^^^^^^ Use double pipes `||` instead.
RUBY
expect_correction(<<~RUBY)
time_period = updated_during || (2.days.ago...Time.now)
RUBY
end
it 'registers an offense and corrects when the else branch contains `rescue`' do
expect_offense(<<~RUBY)
if a
^^^^ Use double pipes `||` instead.
a
else
b rescue c
end
RUBY
expect_correction(<<~RUBY)
a || (b rescue c)
RUBY
end
it 'registers an offense and corrects when the else branch contains `and`' do
expect_offense(<<~RUBY)
if a
^^^^ Use double pipes `||` instead.
a
else
b and c
end
RUBY
expect_correction(<<~RUBY)
a || (b and c)
RUBY
end
end
end
context 'when inverted condition (unless)' do
it 'registers no offense' do
expect_no_offenses(<<~RUBY)
unless a
b
else
c
end
RUBY
end
context 'when condition and else branch are same' do
it 'registers an offense' do
expect_offense(<<~RUBY)
unless b
^^^^^^^^ Use double pipes `||` instead.
y(x, z)
else
b
end
RUBY
expect_correction(<<~RUBY)
b || y(x, z)
RUBY
end
it 'accepts complex unless branches' do
expect_no_offenses(<<~RUBY)
unless b
c
d
else
b
end
RUBY
end
end
end
end