forked from rubocop/rubocop
/
raise_exception_spec.rb
115 lines (98 loc) · 3.38 KB
/
raise_exception_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Lint::RaiseException, :config do
subject(:cop) { described_class.new(config) }
let(:cop_config) { { 'AllowedImplicitNamespaces' => ['Gem'] } }
it 'registers an offense for `raise` with `::Exception`' do
expect_offense(<<~RUBY)
raise ::Exception
^^^^^^^^^^^^^^^^^ Use `StandardError` over `Exception`.
RUBY
end
it 'registers an offense for `raise` with `::Exception.new`' do
expect_offense(<<~RUBY)
raise ::Exception.new 'Error with exception'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `StandardError` over `Exception`.
RUBY
end
it 'registers an offense for `raise` with `::Exception` and message' do
expect_offense(<<~RUBY)
raise ::Exception, 'Error with exception'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `StandardError` over `Exception`.
RUBY
end
it 'registers an offense for `raise` with `Exception`' do
expect_offense(<<~RUBY)
raise Exception
^^^^^^^^^^^^^^^ Use `StandardError` over `Exception`.
RUBY
end
it 'registers an offense for `raise` with `Exception` and message' do
expect_offense(<<~RUBY)
raise Exception, 'Error with exception'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `StandardError` over `Exception`.
RUBY
end
it 'registers an offense for `raise` with `Exception.new` and message' do
expect_offense(<<~RUBY)
raise Exception.new 'Error with exception'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `StandardError` over `Exception`.
RUBY
end
it 'registers an offense for `raise` with `Exception.new(args*)` ' do
expect_offense(<<~RUBY)
raise Exception.new('arg1', 'arg2')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `StandardError` over `Exception`.
RUBY
end
it 'registers an offense for `fail` with `Exception`' do
expect_offense(<<~RUBY)
fail Exception
^^^^^^^^^^^^^^ Use `StandardError` over `Exception`.
RUBY
end
it 'registers an offense for `fail` with `Exception` and message' do
expect_offense(<<~RUBY)
fail Exception, 'Error with exception'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `StandardError` over `Exception`.
RUBY
end
it 'registers an offense for `fail` with `Exception.new` and message' do
expect_offense(<<~RUBY)
fail Exception.new 'Error with exception'
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `StandardError` over `Exception`.
RUBY
end
it 'does not register an offense for `raise` without arguments' do
expect_no_offenses('raise')
end
it 'does not register an offense for `fail` without arguments' do
expect_no_offenses('fail')
end
it 'does not register an offense when raising Exception with explicit ' \
'namespace' do
expect_no_offenses(<<~RUBY)
raise Foo::Exception
RUBY
end
context 'when under namespace' do
it 'does not register an offense when Exception without cbase specified' do
expect_no_offenses(<<~RUBY)
module Gem
def self.foo
raise Exception
end
end
RUBY
end
it 'does not register an offense when Exception with cbase specified' do
expect_offense(<<~RUBY)
module Gem
def self.foo
raise ::Exception
^^^^^^^^^^^^^^^^^ Use `StandardError` over `Exception`.
end
end
RUBY
end
end
end