forked from rubocop/rubocop
/
empty_lines_around_access_modifier.rb
215 lines (177 loc) · 5.94 KB
/
empty_lines_around_access_modifier.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
# frozen_string_literal: true
module RuboCop
module Cop
module Layout
# Access modifiers should be surrounded by blank lines.
#
# @example EnforcedStyle: around (default)
#
# # bad
# class Foo
# def bar; end
# private
# def baz; end
# end
#
# # good
# class Foo
# def bar; end
#
# private
#
# def baz; end
# end
#
# @example EnforcedStyle: only_before
#
# # bad
# class Foo
# def bar; end
# private
# def baz; end
# end
#
# # good
# class Foo
# def bar; end
#
# private
# def baz; end
# end
#
class EmptyLinesAroundAccessModifier < Base
include ConfigurableEnforcedStyle
include RangeHelp
extend AutoCorrector
MSG_AFTER = 'Keep a blank line after `%<modifier>s`.'
MSG_BEFORE_AND_AFTER = 'Keep a blank line before and after ' \
'`%<modifier>s`.'
MSG_BEFORE_FOR_ONLY_BEFORE = 'Keep a blank line before `%<modifier>s`.'
MSG_AFTER_FOR_ONLY_BEFORE = 'Remove a blank line after `%<modifier>s`.'
def initialize(config = nil, options = nil)
super
@block_line = nil
end
def on_class(node)
@class_or_module_def_first_line = if node.parent_class
node.parent_class.first_line
else
node.source_range.first_line
end
@class_or_module_def_last_line = node.source_range.last_line
end
def on_module(node)
@class_or_module_def_first_line = node.source_range.first_line
@class_or_module_def_last_line = node.source_range.last_line
end
def on_sclass(node)
@class_or_module_def_first_line =
node.identifier.source_range.first_line
@class_or_module_def_last_line =
node.source_range.last_line
end
def on_block(node)
@block_line = node.source_range.first_line
end
def on_send(node)
return unless node.bare_access_modifier? && !node.parent&.block_type?
return if expected_empty_lines?(node)
message = message(node)
add_offense(node, message: message) do |corrector|
line = range_by_whole_lines(node.source_range)
corrector.insert_before(line, "\n") unless previous_line_empty?(node.first_line)
correct_next_line_if_denied_style(corrector, node, line)
end
end
private
def expected_empty_lines?(node)
case style
when :around
return true if empty_lines_around?(node)
when :only_before
return true if allowed_only_before_style?(node)
end
false
end
def allowed_only_before_style?(node)
if node.special_modifier?
return true if processed_source[node.last_line] == 'end'
return false if next_line_empty?(node.last_line)
end
previous_line_empty?(node.first_line)
end
def correct_next_line_if_denied_style(corrector, node, line)
case style
when :around
corrector.insert_after(line, "\n") unless next_line_empty?(node.last_line)
when :only_before
if next_line_empty?(node.last_line)
range = next_empty_line_range(node)
corrector.remove(range)
end
end
end
def previous_line_ignoring_comments(processed_source, send_line)
processed_source[0..send_line - 2].reverse.find do |line|
!comment_line?(line)
end
end
def previous_line_empty?(send_line)
previous_line = previous_line_ignoring_comments(processed_source,
send_line)
block_start?(send_line) ||
class_def?(send_line) ||
previous_line.blank?
end
def next_line_empty?(last_send_line)
next_line = processed_source[last_send_line]
body_end?(last_send_line) || next_line.blank?
end
def empty_lines_around?(node)
previous_line_empty?(node.first_line) &&
next_line_empty?(node.last_line)
end
def class_def?(line)
return false unless @class_or_module_def_first_line
line == @class_or_module_def_first_line + 1
end
def block_start?(line)
return false unless @block_line
line == @block_line + 1
end
def body_end?(line)
return false unless @class_or_module_def_last_line
line == @class_or_module_def_last_line - 1
end
def next_empty_line_range(node)
source_range(processed_source.buffer, node.last_line + 1, 0)
end
def message(node)
case style
when :around
message_for_around_style(node)
when :only_before
message_for_only_before_style(node)
end
end
def message_for_around_style(node)
send_line = node.first_line
if block_start?(send_line) ||
class_def?(send_line)
format(MSG_AFTER, modifier: node.loc.selector.source)
else
format(MSG_BEFORE_AND_AFTER, modifier: node.loc.selector.source)
end
end
def message_for_only_before_style(node)
modifier = node.loc.selector.source
if next_line_empty?(node.last_line)
format(MSG_AFTER_FOR_ONLY_BEFORE, modifier: modifier)
else
format(MSG_BEFORE_FOR_ONLY_BEFORE, modifier: modifier)
end
end
end
end
end
end