forked from rubocop/rubocop
/
variable_number_spec.rb
176 lines (153 loc) · 7.1 KB
/
variable_number_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Naming::VariableNumber, :config do
shared_examples 'offense' do |style, variable, style_to_allow_offenses|
it "registers an offense for #{variable} in #{style}" do
expect_offense(<<~RUBY, variable: variable)
#{variable} = 1
^{variable} Use #{style} for variable numbers.
RUBY
expect(cop.config_to_allow_offenses).to eq(
{ 'EnforcedStyle' => style_to_allow_offenses.to_s }
)
end
end
shared_examples 'offense_array' do |style, variables|
it "registers an offense for #{variables} in #{style}" do
lines = variables.map { |v| "#{v} = 1" }
lines.insert(1, "^{first_variable} Use #{style} for variable numbers.")
expect_offense(lines.join("\n"), first_variable: variables.first)
expect(cop.config_to_allow_offenses).to eq({ 'Enabled' => false })
end
end
shared_examples 'accepts' do |style, variable|
it "accepts #{variable} in #{style}" do
expect_no_offenses("#{variable} = 1")
end
end
context 'when configured for snake_case' do
let(:cop_config) { { 'EnforcedStyle' => 'snake_case' } }
it_behaves_like 'offense', 'snake_case', 'local1', :normalcase
it_behaves_like 'offense', 'snake_case', '@local1', :normalcase
it_behaves_like 'offense', 'snake_case', '@@local1', :normalcase
it_behaves_like 'offense', 'snake_case', 'camelCase1', :normalcase
it_behaves_like 'offense', 'snake_case', '@camelCase1', :normalcase
it_behaves_like 'offense', 'snake_case', '_unused1', :normalcase
it_behaves_like 'offense', 'snake_case', 'aB1', :normalcase
it_behaves_like 'offense_array', 'snake_case', %w[a1 a_2]
it_behaves_like 'accepts', 'snake_case', 'local_1'
it_behaves_like 'accepts', 'snake_case', 'local_12'
it_behaves_like 'accepts', 'snake_case', 'local_123'
it_behaves_like 'accepts', 'snake_case', 'local_'
it_behaves_like 'accepts', 'snake_case', 'aB_1'
it_behaves_like 'accepts', 'snake_case', 'a_1_b'
it_behaves_like 'accepts', 'snake_case', 'a_1_b_1'
it_behaves_like 'accepts', 'snake_case', '_'
it_behaves_like 'accepts', 'snake_case', '_foo'
it_behaves_like 'accepts', 'snake_case', '@foo'
it_behaves_like 'accepts', 'snake_case', '@__foo__'
it_behaves_like 'accepts', 'snake_case', 'emparejó'
it 'registers an offense for normal case numbering in method parameter' do
expect_offense(<<~RUBY)
def method(arg1); end
^^^^ Use snake_case for variable numbers.
RUBY
end
it 'registers an offense for normal case numbering in method camel case
parameter' do
expect_offense(<<~RUBY)
def method(funnyArg1); end
^^^^^^^^^ Use snake_case for variable numbers.
RUBY
end
end
context 'when configured for normal' do
let(:cop_config) { { 'EnforcedStyle' => 'normalcase' } }
it_behaves_like 'offense', 'normalcase', 'local_1', :snake_case
it_behaves_like 'offense', 'normalcase', 'sha_256', :snake_case
it_behaves_like 'offense', 'normalcase', '@local_1', :snake_case
it_behaves_like 'offense', 'normalcase', '@@local_1', :snake_case
it_behaves_like 'offense', 'normalcase', 'myAttribute_1', :snake_case
it_behaves_like 'offense', 'normalcase', '@myAttribute_1', :snake_case
it_behaves_like 'offense', 'normalcase', '_myLocal_1', :snake_case
it_behaves_like 'offense', 'normalcase', 'localFOO_1', :snake_case
it_behaves_like 'offense', 'normalcase', 'local_FOO_1', :snake_case
it_behaves_like 'offense_array', 'normalcase', %w[a_1 a2]
it_behaves_like 'accepts', 'normalcase', 'local1'
it_behaves_like 'accepts', 'normalcase', 'local_'
it_behaves_like 'accepts', 'normalcase', 'user1_id'
it_behaves_like 'accepts', 'normalcase', 'sha256'
it_behaves_like 'accepts', 'normalcase', 'foo10_bar'
it_behaves_like 'accepts', 'normalcase', 'target_u2f_device'
it_behaves_like 'accepts', 'normalcase', 'localFOO1'
it_behaves_like 'accepts', 'normalcase', 'snake_case'
it_behaves_like 'accepts', 'normalcase', 'user_1_id'
it_behaves_like 'accepts', 'normalcase', '_'
it_behaves_like 'accepts', 'normalcase', '_foo'
it_behaves_like 'accepts', 'normalcase', '@foo'
it_behaves_like 'accepts', 'normalcase', '@__foo__'
it_behaves_like 'accepts', 'snake_case', 'emparejó'
it 'registers an offense for snake case numbering in method parameter' do
expect_offense(<<~RUBY)
def method(arg_1); end
^^^^^ Use normalcase for variable numbers.
RUBY
end
it 'registers an offense for snake case numbering in method camel case
parameter' do
expect_offense(<<~RUBY)
def method(funnyArg_1); end
^^^^^^^^^^ Use normalcase for variable numbers.
RUBY
end
end
context 'when configured for non integer' do
let(:cop_config) { { 'EnforcedStyle' => 'non_integer' } }
it_behaves_like 'offense', 'non_integer', 'local_1', :snake_case
it_behaves_like 'offense', 'non_integer', 'local1', :normalcase
it_behaves_like 'offense', 'non_integer', '@local_1', :snake_case
it_behaves_like 'offense', 'non_integer', '@local1', :normalcase
it_behaves_like 'offense', 'non_integer', 'myAttribute_1', :snake_case
it_behaves_like 'offense', 'non_integer', 'myAttribute1', :normalcase
it_behaves_like 'offense', 'non_integer', '@myAttribute_1', :snake_case
it_behaves_like 'offense', 'non_integer', '@myAttribute1', :normalcase
it_behaves_like 'offense', 'non_integer', '_myLocal_1', :snake_case
it_behaves_like 'offense', 'non_integer', '_myLocal1', :normalcase
it_behaves_like 'offense_array', 'non_integer', %w[a_1 aone]
it_behaves_like 'accepts', 'non_integer', 'localone'
it_behaves_like 'accepts', 'non_integer', 'local_one'
it_behaves_like 'accepts', 'non_integer', 'local_'
it_behaves_like 'accepts', 'non_integer', '@foo'
it_behaves_like 'accepts', 'non_integer', '@@foo'
it_behaves_like 'accepts', 'non_integer', 'fooBar'
it_behaves_like 'accepts', 'non_integer', '_'
it_behaves_like 'accepts', 'non_integer', '_foo'
it_behaves_like 'accepts', 'non_integer', '@__foo__'
it_behaves_like 'accepts', 'snake_case', 'emparejó'
it 'registers an offense for snake case numbering in method parameter' do
expect_offense(<<~RUBY)
def method(arg_1); end
^^^^^ Use non_integer for variable numbers.
RUBY
end
it 'registers an offense for normal case numbering in method parameter' do
expect_offense(<<~RUBY)
def method(arg1); end
^^^^ Use non_integer for variable numbers.
RUBY
end
it 'registers an offense for snake case numbering in method camel case
parameter' do
expect_offense(<<~RUBY)
def method(myArg_1); end
^^^^^^^ Use non_integer for variable numbers.
RUBY
end
it 'registers an offense for normal case numbering in method camel case
parameter' do
expect_offense(<<~RUBY)
def method(myArg1); end
^^^^^^ Use non_integer for variable numbers.
RUBY
end
end
end