Skip to content

Latest commit

 

History

History
270 lines (185 loc) · 16.4 KB

CHANGELOG.md

File metadata and controls

270 lines (185 loc) · 16.4 KB
Raw

Change log

master (unreleased)

New features

Bug fixes

  • #315: Allow to use frozen scope for Rails/UniqueValidationWithoutIndex. (@krim)
  • #313: Fix Rails/ActiveRecordCallbacksOrder to preserve the original callback execution order. (@eugeneius)
  • #319: Fix a false positive for Rails/Inquiry when #inquiry's receiver is a variable. (@koic)
  • #327: Fix Rails/ContentTag autocorrect to handle html5 tag names with hyphens. (@jaredmoody)

Changes

  • #312: Mark Rails/MailerName as unsafe for auto-correct. (@eugeneius)
  • #294: Update Rails/ReversibleMigration to register offenses for remove_columns and remove_index. (@philcoggins)
  • #310: Add EnforcedStyle to Rails/PluckInWhere. By default, it does not register an offense if pluck method's receiver is a variable. (@koic)
  • #320: Mark Rails/UniqBeforePluck as unsafe auto-correction. (@kunitoo)
  • #324: Make Rails/IndexBy and Rails/IndexWith aware of to_h with block. (@eugeneius)

2.7.1 (2020-07-26)

Bug fixes

  • #297: Handle an upstream Ruby issue where the DidYouMean module is not available, which would break the Rails/UnknownEnv cop. (@taylorthurlow)
  • #300: Fix Rails/RenderInline error on variable key in render options. (@tejasbubane)
  • #305: Fix crash in Rails/MatchRoute cop when via option is a variable. (@tejasbubane)

Changes

  • #301: Set disalbed by default for Rails/PluckId. (@koic)

2.7.0 (2020-07-21)

New features

Bug fixes

  • #261: Fix auto correction for Rails/ContentTag when content_tag is called with options hash and block. (@fatkodima)

Changes

  • #263: Change terminology to ForbiddenMethods and AllowedMethods. (@jcoyne)
  • #289: Update Rails/SkipsModelValidations to register an offense for insert_all, touch_all, upsert_all, etc. (@eugeneius)
  • #293: Require RuboCop 0.87 or higher. (@koic)

2.6.0 (2020-06-08)

New features

Bug fixes

  • #12: Fix a false positive for Rails/SkipsModelValidations when passing a boolean literal to touch. (@eugeneius)
  • #238: Fix auto correction for Rails/IndexBy when the .to_h invocation is separated in multiple lines. (@diogoosorio)
  • #248: Fix a false positive for Rails/SaveBang when update is called on ENV. (@eugeneius)
  • #251: Fix a false positive for Rails/FilePath when the result of Rails.root.join is interpolated at the end of a string. (@eugeneius)
  • #91: Fix Rails/UniqBeforePluck to not recommend using uniq in ActiveRecord::Relations anymore since it was deprecated in Rails 5.0. (@santib, @ghiculescu)

Changes

  • #233: (BREAKING) Drop support for Ruby 2.3. (@koic)
  • #236: (BREAKING) Drop support for Rails 4.1 or lower. (@koic)
  • #210: Accept redirecto_to(...) and return and similar cases. (@koic)
  • #258: Drop support for RuboCop 0.81 or lower. (@koic)

2.5.2 (2020-04-09)

Bug fixes

  • #227: Make Rails/UniqueValidationWithoutIndex aware of updating db/schema.rb. (@koic)

2.5.1 (2020-04-02)

Bug fixes

  • #213: Fix a false positive for Rails/UniqueValidationWithoutIndex when using conditions. (@sunny)
  • #215: Fix a false positive for Rails/UniqueValidationWithoutIndex when using Expression Indexes. (@koic)
  • #214: Fix an error for Rails/UniqueValidationWithoutIndexwhen a table has no column definition. (@koic)
  • #221: Make Rails/UniqueValidationWithoutIndex aware of add_index in db/schema.rb. (@koic)

Changes

  • #223: Mark Rails/ApplicationController, Rails/ApplicationJob, Rails/ApplicationMailer, and Rails/ApplicationRecord as unsafe autocorrect. (@hoshinotsuyoshi)

2.5.0 (2020-03-24)

New features

  • #197: Add Rails/UniqueValidationWithoutIndex cop. (@pocke)
  • #208: Add new Rails/IndexBy and Rails/IndexWith cops. (@djudd, @eugeneius)
  • #150: Add EnforcedStyle: refute for Rails/RefuteMethods cop. (@koic)

Bug fixes

  • #180: Fix a false positive for HttpPositionalArguments when using get method with :to option. (@koic)
  • #193: Make Rails/EnvironmentComparison aware of Rails.env is used in RHS or when != is used for comparison. (@koic)
  • #205: Make Rails/ReversibleMigration aware of :to_table option of remove_foreign_key. (@joshpencheon)
  • #207: Fix a false positive for Rails/RakeEnvironment when using Capistrano. (@sinsoku)

2.4.2 (2020-01-26)

Bug fixes

  • #184: Fix Rake/Environment to allow task with no block. (@hanachin)
  • #122: Fix Exclude paths that were not inherited. (@koic)
  • #187: Fix an issue that excluded files in rubocop-rails did not work. (@sinsoku)
  • #190: Fix Rails/SaveBang when return value is checked immediately. (@jas14)

2.4.1 (2019-12-25)

Bug fixes

  • #170: Make Rails/BulkChangeTable not suggest combining methods with an intervening block. (@mvz)
  • #159: Fix autocorrect for Rails/EnumHash when using % arrays notations. (@ngouy)

Changes

  • #166: Add db/schema.rb and bin/* to the excluded files. (@fidalgo)

2.4.0 (2019-11-27)

New features

  • #123: Add new Rails/ApplicationController and Rails/ApplicationMailer cops. (@eugeneius)
  • #130: Add new Rails/RakeEnvironment cop. (@pocke)
  • #133: Add new Rails/SafeNavigationWithBlank cop. (@gyfis)

Bug fixes

  • #120: Fix message for Rails/SaveBang when the save is in the body of a conditional. (@jas14)
  • #131: Fix an incorrect autocorrect for Rails/Presence when using [] method. (@forresty)
  • #142: Fix an incorrect autocorrect for Rails/EnumHash when using nested constants. (@koic)
  • #136: Fix a false positive for Rails/ReversibleMigration when using change_default with :from and :to options. (@sinsoku)
  • #144: Fix a false positive for Rails/ReversibleMigration when using change_table_comment or change_column_comment with a :from and :to hash. (@DNA)

Changes

  • #156: Make Rails/UnknownEnv cop aware of Rails.env == 'unknown_env'. (@pocke)
  • #141: Change default of EnforcedStyle from arguments to slashes for Rails/FilePath. (@koic)

2.3.2 (2019-09-01)

Bug fixes

  • #118: Fix an incorrect autocorrect for Rails/Validation when attributes are specified with array literal. (@koic)
  • #116: Fix an incorrect autocorrect for Rails/Presence when else branch of ternary operator is not nil. (@koic)

2.3.1 (2019-08-26)

Bug fixes

  • #104: Exclude Rails-independent bin/bundle by default. (@koic)
  • #107: Fix style guide URLs when specifying rubocop --display-style-guide option. (@koic)
  • #111: Fix an incorrect autocorrect for Rails/Presence when method arguments of else branch is not enclosed in parentheses. (@koic)

2.3.0 (2019-08-13)

New features

Bug fixes

  • #53: Fix a false positive for Rails/SaveBang when implicitly return using finder method and creation method connected by ||. (@koic)
  • #97: Fix two false negatives for Rails/EnumUniqueness. 1. When enum name is not a literal. 2. When enum has multiple definitions. (@santib)

Changes

2.2.1 (2019-07-13)

Bug fixes

  • #86: Fix an incorrect auto-correct for Rails/TimeZone when using Time.new. (@koic)

2.2.0 (2019-07-07)

Bug fixes

  • #67: Fix an incorrect auto-correct for Rails/TimeZone when using DateTime. (@koic)

2.1.0 (2019-06-26)

Bug fixes

  • #43: Remove change_column_null method from BulkChangeTable cop offenses. (@anthony-robin)
  • #79: Fix RuboCop::Cop::Rails not defined (NameError). (@rmm5t)

Changes

2.0.1 (2019-06-08)

Changes

2.0.0 (2019-05-22)

New features

  • Extract Rails cops from rubocop-hq/rubocop repository. (@koic)
  • #19: Add new Rails/HelperInstanceVariable cop. (@andyw8)