forked from rubocop/rubocop-performance
/
caller.rb
71 lines (62 loc) · 1.87 KB
/
caller.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
# frozen_string_literal: true
module RuboCop
module Cop
module Performance
# This cop identifies places where `caller[n]`
# can be replaced by `caller(n..n).first`.
#
# @example
# # bad
# caller[1]
# caller.first
# caller_locations[1]
# caller_locations.first
#
# # good
# caller(2..2).first
# caller(1..1).first
# caller_locations(2..2).first
# caller_locations(1..1).first
class Caller < Base
MSG_BRACE = 'Use `%<method>s(%<n>d..%<n>d).first`' \
' instead of `%<method>s[%<m>d]`.'
MSG_FIRST = 'Use `%<method>s(%<n>d..%<n>d).first`' \
' instead of `%<method>s.first`.'
RESTRICT_ON_SEND = %i[first []].freeze
def_node_matcher :slow_caller?, <<~PATTERN
{
(send nil? {:caller :caller_locations})
(send nil? {:caller :caller_locations} int)
}
PATTERN
def_node_matcher :caller_with_scope_method?, <<~PATTERN
{
(send #slow_caller? :first)
(send #slow_caller? :[] int)
}
PATTERN
def on_send(node)
return unless caller_with_scope_method?(node)
message = message(node)
add_offense(node, message: message)
end
private
def message(node)
method_name = node.receiver.method_name
caller_arg = node.receiver.first_argument
n = caller_arg ? int_value(caller_arg) : 1
if node.method?(:[])
m = int_value(node.first_argument)
n += m
format(MSG_BRACE, n: n, m: m, method: method_name)
else
format(MSG_FIRST, n: n, method: method_name)
end
end
def int_value(node)
node.children[0]
end
end
end
end
end