forked from rubocop/rubocop-minitest
-
Notifications
You must be signed in to change notification settings - Fork 0
/
refute_nil.rb
52 lines (46 loc) · 1.38 KB
/
refute_nil.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
# frozen_string_literal: true
module RuboCop
module Cop
module Minitest
# Enforces the test to use `refute_nil` instead of using
# `refute_equal(nil, something)`, `refute(something.nil?)`, or `refute_predicate(something, :nil?)`.
#
# @example
# # bad
# refute_equal(nil, actual)
# refute_equal(nil, actual, 'message')
# refute(actual.nil?)
# refute(actual.nil?, 'message')
# refute_predicate(object, :nil?)
# refute_predicate(object, :nil?, 'message')
#
# # good
# refute_nil(actual)
# refute_nil(actual, 'message')
#
class RefuteNil < Base
include ArgumentRangeHelper
include NilAssertionHandleable
extend AutoCorrector
ASSERTION_TYPE = 'refute'
RESTRICT_ON_SEND = %i[refute refute_equal refute_predicate].freeze
def_node_matcher :nil_refutation, <<~PATTERN
{
(send nil? :refute_equal nil $_ $...)
(send nil? :refute (send $_ :nil?) $...)
(send nil? :refute_predicate $_ (sym :nil?) $...)
}
PATTERN
def on_send(node)
nil_refutation(node) do |actual, message|
register_offense(node, actual, message)
end
end
private
def assertion_type
ASSERTION_TYPE
end
end
end
end
end