forked from rubocop/rubocop-minitest
-
Notifications
You must be signed in to change notification settings - Fork 0
/
global_expectations.rb
167 lines (147 loc) · 5.3 KB
/
global_expectations.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
# frozen_string_literal: true
module RuboCop
module Cop
module Minitest
# Checks for deprecated global expectations
# and autocorrects them to use expect format.
#
# @example EnforcedStyle: any (default)
# # bad
# musts.must_equal expected_musts
# wonts.wont_match expected_wonts
# musts.must_raise TypeError
#
# # good
# _(musts).must_equal expected_musts
# _(wonts).wont_match expected_wonts
# _ { musts }.must_raise TypeError
#
# expect(musts).must_equal expected_musts
# expect(wonts).wont_match expected_wonts
# expect { musts }.must_raise TypeError
#
# value(musts).must_equal expected_musts
# value(wonts).wont_match expected_wonts
# value { musts }.must_raise TypeError
#
# @example EnforcedStyle: _
# # bad
# musts.must_equal expected_musts
# wonts.wont_match expected_wonts
# musts.must_raise TypeError
#
# expect(musts).must_equal expected_musts
# expect(wonts).wont_match expected_wonts
# expect { musts }.must_raise TypeError
#
# value(musts).must_equal expected_musts
# value(wonts).wont_match expected_wonts
# value { musts }.must_raise TypeError
#
# # good
# _(musts).must_equal expected_musts
# _(wonts).wont_match expected_wonts
# _ { musts }.must_raise TypeError
#
# @example EnforcedStyle: expect
# # bad
# musts.must_equal expected_musts
# wonts.wont_match expected_wonts
# musts.must_raise TypeError
#
# _(musts).must_equal expected_musts
# _(wonts).wont_match expected_wonts
# _ { musts }.must_raise TypeError
#
# value(musts).must_equal expected_musts
# value(wonts).wont_match expected_wonts
# value { musts }.must_raise TypeError
#
# # good
# expect(musts).must_equal expected_musts
# expect(wonts).wont_match expected_wonts
# expect { musts }.must_raise TypeError
#
# @example EnforcedStyle: value
# # bad
# musts.must_equal expected_musts
# wonts.wont_match expected_wonts
# musts.must_raise TypeError
#
# _(musts).must_equal expected_musts
# _(wonts).wont_match expected_wonts
# _ { musts }.must_raise TypeError
#
# expect(musts).must_equal expected_musts
# expect(wonts).wont_match expected_wonts
# expect { musts }.must_raise TypeError
#
# # good
# value(musts).must_equal expected_musts
# value(wonts).wont_match expected_wonts
# value { musts }.must_raise TypeError
class GlobalExpectations < Base
include ConfigurableEnforcedStyle
extend AutoCorrector
MSG = 'Use `%<preferred>s` instead.'
VALUE_MATCHERS = %i[
must_be_empty must_equal must_be_close_to must_be_within_delta
must_be_within_epsilon must_include must_be_instance_of must_be_kind_of
must_match must_be_nil must_be must_respond_to must_be_same_as
path_must_exist path_wont_exist wont_be_empty wont_equal wont_be_close_to
wont_be_within_delta wont_be_within_epsilon wont_include wont_be_instance_of
wont_be_kind_of wont_match wont_be_nil wont_be wont_respond_to wont_be_same_as
].freeze
BLOCK_MATCHERS = %i[
must_output must_pattern_match must_raise must_be_silent must_throw wont_pattern_match
].freeze
RESTRICT_ON_SEND = VALUE_MATCHERS + BLOCK_MATCHERS
# There are aliases for the `_` method - `expect` and `value`
DSL_METHODS = %i[_ expect value].freeze
def on_send(node)
receiver = node.receiver
return unless receiver
method = block_receiver?(receiver) || value_receiver?(receiver)
return if method == preferred_method || (method && style == :any)
register_offense(node, method)
end
private
def_node_matcher :block_receiver?, <<~PATTERN
(block (send nil? $#method_allowed?) _ _)
PATTERN
def_node_matcher :value_receiver?, <<~PATTERN
(send nil? $#method_allowed? _)
PATTERN
def method_allowed?(method)
DSL_METHODS.include?(method)
end
def preferred_method
style == :any ? :_ : style
end
def preferred_receiver(node)
receiver = node.receiver
if BLOCK_MATCHERS.include?(node.method_name)
body = receiver.lambda? ? receiver.body : receiver
"#{preferred_method} { #{body.source} }"
else
"#{preferred_method}(#{receiver.source})"
end
end
def register_offense(node, method)
receiver = node.receiver
if method
preferred = preferred_method
replacement = receiver.source.sub(method.to_s, preferred_method.to_s)
else
preferred = preferred_receiver(node)
replacement = preferred
end
message = format(MSG, preferred: preferred)
add_offense(receiver, message: message) do |corrector|
corrector.replace(receiver, replacement)
end
end
end
end
end
end