forked from rubocop/rubocop-minitest
/
refute_equal.rb
67 lines (56 loc) · 2.09 KB
/
refute_equal.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
# frozen_string_literal: true
module RuboCop
module Cop
module Minitest
# This cop enforces the use of `refute_equal(expected, object)`
# over `assert(expected != actual)` or `assert(! expected == actual)`.
#
# @example
# # bad
# assert("rubocop-minitest" != actual)
# assert(! "rubocop-minitest" == actual)
#
# # good
# refute_equal("rubocop-minitest", actual)
#
class RefuteEqual < Base
include ArgumentRangeHelper
extend AutoCorrector
MSG = 'Prefer using `refute_equal(%<preferred>s)` over ' \
'`assert(%<over>s)`.'
RESTRICT_ON_SEND = %i[assert].freeze
def_node_matcher :assert_not_equal, <<~PATTERN
(send nil? :assert ${(send $_ :!= $_) (send (send $_ :! ) :== $_) } $... )
PATTERN
def on_send(node)
preferred, over = process_not_equal(node)
return unless preferred && over
assert_not_equal(node) do |_, expected, actual|
message = format(MSG, preferred: preferred, over: over)
add_offense(node, message: message) do |corrector|
corrector.replace(node.loc.selector, 'refute_equal')
replacement = [expected, actual].map(&:source).join(', ')
corrector.replace(first_argument_range(node), replacement)
end
end
end
private
def preferred_usage(first_arg, second_arg, custom_message = nil)
[first_arg, second_arg, custom_message]
.compact.map(&:source).join(', ')
end
def original_usage(first_part, custom_message)
[first_part, custom_message].compact.join(', ')
end
def process_not_equal(node)
assert_not_equal(node) do |over, first_arg, second_arg, rest_args|
custom_message = rest_args.first
preferred = preferred_usage(first_arg, second_arg, custom_message)
over = original_usage(over.source, custom_message&.source)
return [preferred, over]
end
end
end
end
end
end