forked from rubocop/rubocop-minitest
/
literal_as_actual_argument.rb
53 lines (45 loc) · 1.42 KB
/
literal_as_actual_argument.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
# frozen_string_literal: true
module RuboCop
module Cop
module Minitest
# This cop enforces correct order of expected and
# actual arguments for `assert_equal`.
#
# @example
# # bad
# assert_equal foo, 2
# assert_equal foo, [1, 2]
# assert_equal foo, [1, 2], 'message'
#
# # good
# assert_equal 2, foo
# assert_equal [1, 2], foo
# assert_equal [1, 2], foo, 'message'
#
class LiteralAsActualArgument < Cop
include ArgumentRangeHelper
MSG = 'Replace the literal with the first argument.'
RESTRICT_ON_SEND = %i[assert_equal].freeze
def on_send(node)
return unless node.method?(:assert_equal)
actual = node.arguments[1]
return unless actual
add_offense(node, location: all_arguments_range(node)) if actual.recursive_basic_literal?
end
def autocorrect(node)
expected, actual, message = *node.arguments
lambda do |corrector|
new_actual_source =
if actual.hash_type? && !actual.braces?
"{#{actual.source}}"
else
actual.source
end
arguments = [new_actual_source, expected.source, message&.source].compact.join(', ')
corrector.replace(node, "assert_equal(#{arguments})")
end
end
end
end
end
end