forked from rubocop/rubocop-minitest
/
assert_truthy.rb
52 lines (45 loc) · 1.43 KB
/
assert_truthy.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
# frozen_string_literal: true
module RuboCop
module Cop
module Minitest
# This cop enforces the test to use `assert(actual)`
# instead of using `assert_equal(true, actual)`.
#
# @example
# # bad
# assert_equal(true, actual)
# assert_equal(true, actual, 'message')
#
# # good
# assert(actual)
# assert(actual, 'message')
#
class AssertTruthy < Cop
include ArgumentRangeHelper
MSG = 'Prefer using `assert(%<arguments>s)` over ' \
'`assert_equal(true, %<arguments>s)`.'
RESTRICT_ON_SEND = %i[assert_equal].freeze
def_node_matcher :assert_equal_with_truthy, <<~PATTERN
(send nil? :assert_equal true $_ $...)
PATTERN
def on_send(node)
assert_equal_with_truthy(node) do |actual, rest_receiver_arg|
message = rest_receiver_arg.first
arguments = [actual.source, message&.source].compact.join(', ')
add_offense(node, message: format(MSG, arguments: arguments))
end
end
def autocorrect(node)
lambda do |corrector|
assert_equal_with_truthy(node) do |actual|
corrector.replace(node.loc.selector, 'assert')
corrector.replace(
first_and_second_arguments_range(node), actual.source
)
end
end
end
end
end
end
end