forked from rubocop/rubocop-minitest
/
refute_nil.rb
52 lines (45 loc) · 1.41 KB
/
refute_nil.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
# frozen_string_literal: true
module RuboCop
module Cop
module Minitest
# This cop enforces the test to use `refute_nil`
# instead of using `refute_equal(nil, something)`.
#
# @example
# # bad
# refute_equal(nil, actual)
# refute_equal(nil, actual, 'message')
#
# # good
# refute_nil(actual)
# refute_nil(actual, 'message')
#
class RefuteNil < Cop
include ArgumentRangeHelper
MSG = 'Prefer using `refute_nil(%<arguments>s)` over ' \
'`refute_equal(nil, %<arguments>s)`.'
RESTRICT_ON_SEND = %i[refute_equal].freeze
def_node_matcher :refute_equal_with_nil, <<~PATTERN
(send nil? :refute_equal nil $_ $...)
PATTERN
def on_send(node)
refute_equal_with_nil(node) do |actual, message|
message = message.first
arguments = [actual.source, message&.source].compact.join(', ')
add_offense(node, message: format(MSG, arguments: arguments))
end
end
def autocorrect(node)
lambda do |corrector|
refute_equal_with_nil(node) do |actual|
corrector.replace(node.loc.selector, 'refute_nil')
corrector.replace(
first_and_second_arguments_range(node), actual.source
)
end
end
end
end
end
end
end