-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Well formated descriptions is not visible #10292
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Can we please also get a release before the drop? So description is not missing? |
Sure yes |
Co-authored-by: Hassnian <44554284+hassnian@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a quick fix code LGTM
what's the reason of metadata
being defined and meta
being null ?
I'm not sure. Is it possible to fix this case also on the indexer side? @vikiival |
Very slow image worker |
Just FYI, this PR also fixed the missing https://deploy-preview-10292--koda-canary.netlify.app/base/collection/0x3c93690bbe585475fdfadab3f59b4604008c7ac4 |
In this case, I think it's better to fix it on the indexer side. Retry the fetch on this one Because it's expected to be slow at the first request, FYI, the reason image workers exist is to speed up that downside. On the second request, it should be faster. |
Code Climate has analyzed commit dbbefa2 and detected 0 issues on this pull request. View more on Code Climate. |
Quality Gate passedIssues Measures |
After adding retry logic, can we guarantee that every collection will have |
yes, please |
If the problem is because of timeout while fetching the ipfs gateway, it should be fixed with that |
Thank you for your contribution to the Koda - Generative Art Marketplace.
👇 __ Let's make a quick check before the contribution.
PR Type
Needs QA check
Context
Did your issue had any of the "$" label on it?
Screenshot 📸