Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Button style bug #10300

Merged
merged 4 commits into from
May 16, 2024
Merged

Fix: Button style bug #10300

merged 4 commits into from
May 16, 2024

Conversation

springshine0925
Copy link
Contributor

@springshine0925 springshine0925 commented May 15, 2024 •
edited by hassnian

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ahp/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    Screenshot_7

@springshine0925 springshine0925 requested a review from a team as a code owner May 15, 2024 02:09
@springshine0925 springshine0925 requested review from daiagi and hassnian and removed request for a team May 15, 2024 02:09
@netlify Netlify
Copy link

netlify bot commented May 15, 2024 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 568f0a9
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66447e6a21145e00081fff2e
😎 Deploy Preview https://deploy-preview-10300--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian hassnian changed the title Fix:Button style bug #10269 Fix: Button style bug May 15, 2024
hassnian
hassnian requested changes May 15, 2024
View reviewed changes
Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls use tailwind instate

@codeclimate CodeClimate
Copy link

codeclimate bot commented May 15, 2024

Code Climate has analyzed commit 568f0a9 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label May 16, 2024
@prury prury added this pull request to the merge queue May 16, 2024
Merged via the queue into kodadot:main with commit c2b249e May 16, 2024
19 checks passed
@springshine0925
Copy link
Contributor Author

Thanks all of you.
I will do my best in the future.

This was referenced Jun 3, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daiagi daiagi daiagi approved these changes

@hassnian hassnian hassnian approved these changes

Assignees
No one assigned
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button style bug
4 participants
@springshine0925 @daiagi @hassnian @prury