Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button states (active, focus) - revisions #10210

Open
exezbcz opened this issue May 4, 2024 · 5 comments · May be fixed by #10375
Open

Button states (active, focus) - revisions #10210

exezbcz opened this issue May 4, 2024 · 5 comments · May be fixed by #10375
Assignees
@hassnian
Labels
bug Something isn't working p2 core functionality, or is affecting 60% of app visual change not affecting ux of app

Comments

@exezbcz
Copy link
Member

exezbcz commented May 4, 2024

followup for:

in the components, there is defined focus state, by focus state i mean the state that happens when you navigate tab using tab

image

  • it should not be the state when you hold the button

image

on thing are dropdowns, when clicking, it turns the black stroke to white one

image

https://www.figma.com/file/JXNtryaNYhY0XJNArzvPQx/Handoff?type=design&node-id=5311-18771&mode=design&t=wIR4vUyhVh1KHnUu-11
@exezbcz exezbcz added p3 non-core, affecting less than 40% visual change not affecting ux of app labels May 4, 2024
@exezbcz exezbcz mentioned this issue May 4, 2024
Open
@exezbcz
Copy link
Member Author

exezbcz commented May 4, 2024

this should not really be a focus state
image

that should be "active"

@exezbcz
Copy link
Member Author

exezbcz commented May 5, 2024

would probably need more revisions

Screen.Recording.2024-05-05.at.16.49.10.mov

@exezbcz exezbcz changed the title Button focus state Button states (active, focus) - revisions May 5, 2024
@exezbcz exezbcz added p2 core functionality, or is affecting 60% of app bug Something isn't working and removed p3 non-core, affecting less than 40% labels May 5, 2024
@roiLeo roiLeo mentioned this issue May 6, 2024
Merged
3 tasks
@exezbcz
Copy link
Member Author

exezbcz commented May 6, 2024

dropdown styling should also be a bit different

mainly there should not be a hover animation after the button is already active

Screen.Recording.2024-05-06.at.18.22.28.mov

can any CSS ninja jump on this please @kodadot/internal-dev

@Victor0355
Copy link

👋

@Victor0355 Victor0355 mentioned this issue May 12, 2024
Closed
5 tasks
@exezbcz
Copy link
Member Author

exezbcz commented May 23, 2024

@hassnian probably or?

@hassnian hassnian self-assigned this May 30, 2024
@hassnian hassnian linked a pull request May 30, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hassnian hassnian

Labels
bug Something isn't working p2 core functionality, or is affecting 60% of app visual change not affecting ux of app
Projects
None yet
Milestone
No milestone
3 participants
@hassnian @exezbcz @Victor0355